-
Notifications
You must be signed in to change notification settings - Fork 416
libmamba/2024.11.22 package update #34953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
octo-sts
bot
commented
Nov 22, 2024
|
Gen AI suggestions to solve the build error: • Detected Error: "Error: rpc error: code = NotFound desc = federate identity: rpc error: code = NotFound desc = no identity found for (https://accounts.google.com, 109346087047205543085)" • Error Category: Authentication/Configuration • Failure Point: Initial build setup when attempting to authenticate with Google accounts • Root Cause Analysis: The build system is attempting to authenticate with Google accounts for accessing repositories but lacks proper authentication configuration. This is likely related to the presubmit checks configuration. • Suggested Fix:
environment:
contents:
keyring:
- https://packages.wolfi.dev/os/wolfi-signing.rsa.pub
repositories:
- https://packages.wolfi.dev/os
- https://packages.wolfi.dev/bootstrap
• Explanation: The error indicates an authentication issue with Google accounts, but for basic package building in Wolfi, we only need access to the Wolfi repositories. The fix configures direct access to Wolfi repositories without requiring Google authentication. • Additional Notes:
• References:
|
|
Gen AI suggestions to solve the build error: • Detected Error: "patching file libmamba/CMakeLists.txt • Error Category: Configuration • Failure Point: Patch application step in the build pipeline • Root Cause Analysis: • Suggested Fix:
# Generate a new patch from the current source
git checkout -b patch-update 2024.11.22
# Make your changes to libmamba/CMakeLists.txt
git diff > support-shared-libs.patch
pipeline:
- uses: git-checkout
with:
expected-commit: 282b88b4b8f139cfa660c233807ed6d23a12d064
repository: https://github.com/mamba-org/mamba
tag: ${{package.version}}
- runs: |
sed -i '445i\ LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}' libmamba/CMakeLists.txt
- uses: cmake/configure
# ... rest of pipeline• Explanation: • Additional Notes:
• References:
|
Signed-off-by: wolfi-bot <[email protected]>
1bc14f7 to
7aa3f6d
Compare
|
Gen AI suggestions to solve the build error: Based on the error output, I can provide a specific analysis and solution: • Detected Error: • Error Category: Authentication/Configuration • Failure Point: Pre-build authentication step when accessing Wolfi's presubmit repository • Root Cause Analysis: The build is failing because it's trying to authenticate with Google accounts for accessing the presubmit repository but lacks proper authentication credentials. • Suggested Fix:
environment:
contents:
repositories:
- https://packages.wolfi.dev/os
packages:
# existing packages...
• Explanation: • Additional Notes:
• References:
The fix should allow the build to proceed while maintaining access to all required packages through the public Wolfi repository. |
|
Gen AI suggestions to solve the build error: Based on the error output and the Melange YAML file, I'll analyze and provide specific fixes: • Detected Error: The build appears to fail during the git checkout phase, specifically with the message "git commit for build config not provided" • Error Category: Version/Configuration • Failure Point: git-checkout step in the pipeline • Root Cause Analysis: The build system is unable to verify the git commit hash against the provided tag. This often happens when there's a mismatch between the version tag and commit hash, or when the tag format doesn't match the repository's tag scheme. • Suggested Fix:
package:
version: "1.5.8" # Use the actual tagged version
pipeline:
- uses: git-checkout
with:
repository: https://github.com/mamba-org/mamba
tag: "libmamba-${{package.version}}" # Add prefix if needed
expected-commit: "282b88b4b8f139cfa660c233807ed6d23a12d064"• Explanation: The current version "2024.11.22" doesn't appear to match mamba's versioning scheme. Looking at their repository, they use semantic versioning (e.g., 1.5.8). The tag should match the exact format used in the upstream repository. • Additional Notes:
• References:
To verify the fix:
|
|
Updated the patch based on upstream changes and what was in the patch previously. |
|
Test is failing, otherwise the build should be fixed, assuming it's not related to the test failing :) |
|
This looks like test caused a legit regression. I will continue to investigate |
|
No progress so far. we need to be very careful merging this as the testing is not comprehensive and does libmamba is a dependency of other packages and images (see https://github.com/chainguard-dev/internal-dev/issues/6204 for context) |
|
@philroche this popped onto my radar due to working on #36030, which had me staring at the CMake files for this upstream way too long. When CI told me that there was a newer upstream available, I found this PR and realized that the build system seemed to have regressed in a number of ways. But I think the reality is that we've made an incorrect assumption. Notice that both of these releases were created on the same day:
Our version stream automation is trying to upgrade from the tag |
|
I tinkered with this a little bit during a flight: #36183 Let me know what you think @philroche. I'll pause here until we have an agreed path forward. |
|
superseded by #36620 |