Repository navigation
Add Expressive Code missing translations based on Astro Docs - #4160
Conversation
🦋 Changeset detectedLatest commit: f8c73fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
size-limit report 📦
|
delucis
left a comment
delucis
left a comment
There was a problem hiding this comment.
Awesome! Thanks for following up on this and taking the time to figure out which ones it made sense to copy.
I only spotted one potential change, although, like you, I can’t judge the translation quality itself. But I also trust the Astro Docs process and these should definitely be better than no translation.
|
Thanks for the contribution and detailed PR description! The PR overall looks really solid. However, one thing I noticed were differences between translations of the tooltip: Expressive Code itself uses However, these two languages seem to only translate the string Russian could easily be fixed by taking over the translation string from Astro docs: 
For Italian, we might want to get help from a native-speaker from Discord 🤔 |
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
|
@trueberryless Yeah, I noticed the difference. However, I don't know what the common usage is in those languages: just because a machine translation tool suggests something doesn't mean it's the expression actually used. Perhaps the concept of a "clipboard" doesn't add any value for them? But, if we think this is problematic vs falling back to English; I don't mind removing them. |
delucis
left a comment
delucis
left a comment
There was a problem hiding this comment.
Thanks @ArmandPhilippot 🙌
Re: @trueberryless’s last comment — I definitely trust the human translators over machine translation, so I’m happy to accept these and can always tweak based on native speaker feedback if we get some in the future.
* main: [ci] release (withastro#4161) feat: add npmx icon (withastro#4159) Add Hypothesis icon (withastro#4156) Add Expressive Code missing translations based on Astro Docs (withastro#4160) docs: add herdr showcase (withastro#4158)
* main: [ci] release (withastro#4161) feat: add npmx icon (withastro#4159) Add Hypothesis icon (withastro#4156) Add Expressive Code missing translations based on Astro Docs (withastro#4160) docs: add herdr showcase (withastro#4158) [i18nIgnore] docs: reduce 3rd party content weight in search results (withastro#4143)
![Renovate [bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@astrojs/starlight](https://starlight.astro.build) ([source](https://github.com/withastro/starlight/tree/HEAD/packages/starlight)) | [`0.41.9` → `0.41.10`](https://renovatebot.com/diffs/npm/@astrojs%2fstarlight/0.41.9/0.41.10) |  |  | --- ### Release Notes <details> <summary>withastro/starlight (@​astrojs/starlight)</summary> ### [`v0.41.10`](https://github.com/withastro/starlight/blob/HEAD/packages/starlight/CHANGELOG.md#04110) [Compare Source](https://github.com/withastro/starlight/compare/@astrojs/starlight@0.41.9...@astrojs/starlight@0.41.10) ##### Patch Changes - [#​4160](withastro/starlight#4160) [`88442c3`](withastro/starlight@88442c3) Thanks [@​ArmandPhilippot](https://github.com/ArmandPhilippot)! - Adds the missing translations for Expressive Code in the following locales: `ar`, `hi`, `it`, `ja`, `ko`, `pt`, `zh-CN`, and `zh-TW`. - [#​4156](withastro/starlight#4156) [`57af92d`](withastro/starlight@57af92d) Thanks [@​pyxelr](https://github.com/pyxelr)! - Adds 1 new icon: `hypothesis` - [#​4159](withastro/starlight#4159) [`a0e0ba2`](withastro/starlight@a0e0ba2) Thanks [@​trueberryless](https://github.com/trueberryless)! - Adds 1 new icon: `npmx` </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC41Mi4xIiwidXBkYXRlZEluVmVyIjoiNDQuNTIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
5 participants
Description
Follow-up on withastro/docs#14460 (comment)
Expressive Code only has English and German translations built-in. Astro Docs has more translations: we should take advantage of this to upstream the missing translations to Starlight.
I only included the missing ones:
ar,de,hi,it,ja,ko,pt,zh-CN, andzh-TW.The following are not included:
es: Astro Docs / Starlight (seems identical)pl: Astro Docs / Starlight (seems identical)ru: Astro Docs / Starlight (expressiveCode.copyButtonTooltipseems different)And, I haven't checked if the translation are correct... I trust Astro Docs translators. 😅