-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error recovery #705
Conversation
🦋 Changeset detectedLatest commit: fe86fa9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I'm not sure how I feel about the stacktrace being JS like. Even though those are nicer than Go's, I feel like modifying "technical" information can lead to more problems unnecessarily. Sure, they don't scare users as much, but someone used to Go's stacktraces will just find it weird (+ I'm guessing you can't CTRL+click them like you'd do with JS's) |
Alright, thanks for the comments! After thinking about it, I totally agree that transforming the stacktraces is probably going to cause more issues than it will help, so I've removed that logic in c584433. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing, so nice to see the error in the new overlay!
Changes
panic
s so that we actually reject thetransform
promise with the correct error instead of just printing the error to stdout.Trims irrelevant info from the stacktrace and formats to more helpful internal file location.Formats errors similarly to JS stacktraces so that they don't confuse usersTesting
Tested manually
Docs
N/A, QoL improvement