Prevent double uri decoding

[bluwy]

Changes

Fix #7374

Prevent unnecessary decoding in certain places. I'll add comments below to explain it.

Testing

Added a test

Docs

n/a. bug fix.

[changeset-bot]

🦋 Changeset detected

Latest commit: 1692f1e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[bluwy]

This getParams function is being called at

astro/packages/astro/src/core/render/params-and-props.ts

Lines 63 to 72 in cf993bc

	function getRouteParams(route: RouteData, pathname: string): Params | undefined {
	if (route.params.length) {
	// The RegExp pattern expects a decoded string, but the pathname is encoded
	// when the URL contains non-English characters.
	const paramsMatch = route.pattern.exec(decodeURIComponent(pathname));
	if (paramsMatch) {
	return getParams(route.params)(paramsMatch);
	}
	}
	}

As shown, it already calls decodeURIComponent, so we don't have to call decodeURIComponent here too.

[bluwy]

It doesn't look like we need to decode it here. It also doesn't work well with the line below:

astro/packages/astro/src/vite-plugin-astro-server/request.ts

Lines 43 to 44 in cf993bc

	// Add config.base back to url before passing it to SSR
	url.pathname = removeTrailingForwardSlash(config.base) + url.pathname;

(URLs are always encoded)

Removing this decodeURI seems to not break things. It affects dev only. The prod SSR "app" also doesn't decode the url, so I think this makes it more consistent.