Route parameter with uri-encoded percent sign character (%) causes error in SSR

[jwulf0]

What version of astro are you using?

2.6.3

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Mac

What browser are you using?

Firefox (the problem is with SSR though)

Describe the Bug

When calling a path with an uri-encoded route parameter which contains the % character, an error is rendered instead of the expected page. Please see the repo with minimal reproducable example for more details.

I would expect to be able to provide such a route parameter as long as it's properly URI-encoded. Please let me know if I am wrong to expect that.

Looking at the stack trace and following the code, I am rather sure that this is caused by decodeURIComponent being called with a value that has been previously decoded via decodeURIComponent or decodeURI. This causes a string containing a percent sign without two following digits to be provided to the decodeURIComponent function.

Link to Minimal Reproducible Example

https://github.com/jwulf0/astro-uri-decode-bug-minimal

Participation

• I am willing to submit a pull request for this issue.

[jwulf0]

Note: Just updated the minimal reproducible example to make it "more minimal".