Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure injectRoute works during build #7986

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

natemoo-re
Copy link
Member

Changes

  • In Fix injectRoute #7943, we missed the fact that the integrations container plugin was only applied during dev
  • This updates the logic to ensure the integrations container plugin can always run
  • Adds guard to only run server:setup hooks during dev
  • Adds guard to only run resolveInjectedRoutes during server build (otherwise, buildStart runs twice)

Testing

Tested manually because monorepo

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2023

🦋 Changeset detected

Latest commit: ddac77f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 7, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May this PR be blessed with all good things as it sets sail under the starlight ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants