Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix injectRoute #7943

Merged
merged 12 commits into from
Aug 7, 2023
Merged

Fix injectRoute #7943

merged 12 commits into from
Aug 7, 2023

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Aug 3, 2023 •
edited
Loading

Changes

Testing

Manually confirmed, hard to test because it’s a workspace/dependency thing.

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 16a4929

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 3, 2023
@delucis delucis mentioned this pull request Aug 4, 2023
Closed
1 task
@natemoo-re natemoo-re marked this pull request as ready for review August 4, 2023 23:43
@natemoo-re natemoo-re requested a review from a team as a code owner August 4, 2023 23:43
delucis
delucis approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for tackling @natemoo-re! Left two nits, but LGTM!

.changeset/stupid-pants-press.md Outdated Show resolved Hide resolved
packages/astro/src/vite-plugin-scripts/page-ssr.ts Outdated Show resolved Hide resolved
bluwy
bluwy approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, else this lgtm!

packages/astro/src/vite-plugin-integrations-container/index.ts Outdated Show resolved Hide resolved
@natemoo-re natemoo-re merged commit c2682a1 into main Aug 7, 2023
@natemoo-re natemoo-re deleted the fix/inject-route branch August 7, 2023 16:24
@astrobot-houston astrobot-houston mentioned this pull request Aug 7, 2023
Merged
@natemoo-re natemoo-re mentioned this pull request Aug 7, 2023
Merged
@jlarmstrongiv jlarmstrongiv mentioned this pull request Aug 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@matthewp matthewp matthewp approved these changes

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Injected scripts not injected to non-local injected routes
4 participants
@natemoo-re @delucis @matthewp @bluwy