Fix CSS chunking between multiple framework components #6582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 54f9616 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
This comment was marked as outdated.
This comment was marked as outdated.
bluwy
commented
Apr 6, 2023
Comment on lines
-136
to
-146
| // In the client build, we bail if the chunk is a duplicated CSS chunk tracked from | ||
| // above. We remove all the importedCss to prevent emitting the CSS asset. | ||
| if (options.target === 'client') { | ||
| if (Object.keys(c.modules).every((id) => internals.cssChunkModuleIds.has(id))) { | ||
| for (const importedCssImport of meta.importedCss) { | ||
| delete bundle[importedCssImport]; | ||
| meta.importedCss.delete(importedCssImport); | ||
| } | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
This block is removed in favour of the transform() hook, which does the same thing, and should be safer.
matthewp
approved these changes
Apr 12, 2023
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #6524
Fix #6395
When we use
manualChunksto give a name for CSS chunks, we based on all the parent top-level.astropage related to that CSS chunk to create a name and hash.However, for CSS chunks during the client build, where the build inputs are the framework components, it's not possible to do so. This PR skips the custom chunk handling for client builds.
But the above change indirectly regresses #4566, so I fixed it by changing our CSS dedupe handling in a
transform()hook instead ofrenderChunk().Testing
Added a test based on both issue repros, also updated some tests due to new chunking behaviour.
Docs
n/a. bug fix.