Remove unused CSS for client:load components
#4566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8502e4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
commented
Aug 31, 2022
Comment on lines
-8
to
-9
| // Pure CSS chunks are chunks that only contain CSS. | ||
| pureCSSChunks: Set<RenderedChunk>; |
There was a problem hiding this comment.
pureCSSChunks was previously unused. I've re-purposed it as cssChunkModuleIds.
bholmesdev
approved these changes
Aug 31, 2022
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As
client:loadcomponents are built in ssr and client, this PR removes the unused CSS in the client build as SSR already builds one for it.We fix this by tracking all CSS chunks' modules in SSR, then compare them in the client build, removing CSS chunks that also has the same modules.
Thanks @matthewp for the idea.
Testing
Add a test in 0-css
Docs
N/A