Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the before-hydration script #4042

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Build the before-hydration script #4042

merged 2 commits into from
Jul 25, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • The astro-scripts plugin was conditionally building out the before-hydration script only if it thought it needed to. This condition was based on how the build previously worked but no longer does, resulting in this script never being generated.
  • Changed it so that we always build the before-hydration script if there is one to build. It will only be used by components that need it anyways (it's dynamically imported), so there's no problem building it.
  • Closes 🐛 BUG: [build] duplicate lit components #3785

Testing

  • e2e Lit tests re-enabled.
  • Added test to ensure there's only 1 instance of this component.

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2022

🦋 Changeset detected

Latest commit: ff86869

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 25, 2022
@matthewp matthewp merged commit 7e5ac1f into main Jul 25, 2022
@matthewp matthewp deleted the lit-dupe branch July 25, 2022 16:14
@astrobot-houston astrobot-houston mentioned this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: [build] duplicate lit components
2 participants