Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: [build] duplicate lit components #3785

Closed
1 task
Geoffrey-Pliez opened this issue Jul 1, 2022 · 2 comments · Fixed by #4042
Closed
1 task

🐛 BUG: [build] duplicate lit components #3785

Geoffrey-Pliez opened this issue Jul 1, 2022 · 2 comments · Fixed by #4042
Assignees
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)

Comments

@Geoffrey-Pliez
Copy link
Contributor

What version of astro are you using?

1.0.0 - beta.61

Are you using an SSR adapter? If so, which one?

none

What package manager are you using?

npm

What operating system are you using?

Windows

Describe the Bug

Hello,

since patch "Updates an error handler to expect updated @astrojs/lit behavior #3766" , the build version displays the component several times.

my-counter in framework-lit example has this behavior.
I think that build version of this example displays no hydrated version of this component and his hydrated version.
So it does not hydrate the existing component.

Thanks

Link to Minimal Reproducible Example

https://astro.new/framework-lit

Participation

  • I am willing to submit a pull request for this issue.
@tony-sull tony-sull added - P4: important Violate documented behavior or significantly impacts performance (priority) s2-medium labels Jul 1, 2022
@tony-sull
Copy link
Contributor

Could have sworn I opened an issue for this when fixing the urgent #3766 issue, but now I can't find it! Must have gotten lost on a background tab, thanks for opening this to track!

That's definitely an important one, we'll try to jump on this one quickly

@Geoffrey-Pliez
Copy link
Contributor Author

Geoffrey-Pliez commented Jul 5, 2022

Hi,

after a few tries I noticed that everything works fine with astro 1.0.0-beta.46 and after upgrading to 47 the duplicates appear.
So it's one of the changes in version 47 that creates the duplicates.
We need to investigate this side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants