Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates an error handler to expect updated @astrojs/lit behavior #3766

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

tony-sull
Copy link
Contributor

Closes #3741

Changes

Handles an edge case where the @astrojs/lit renderer actually doesn't need to include a client entrypoint since it builds plain old custom elements. It's a one-off check for now, could be interesting to revisit a more general solution if we see a third-party custom element renderer also hit this issue

Also updates example apps that use lit for the newer syntax that removed the export const tagName convention

Testing

All existing tests should pass

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2022

⚠️ No Changeset found

Latest commit: 35673ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) labels Jun 29, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tony-sull tony-sull merged commit 51d5dc4 into main Jun 29, 2022
@tony-sull tony-sull deleted the fix/lib-starter branch June 29, 2022 20:56
tony-sull pushed a commit that referenced this pull request Jun 29, 2022
tony-sull pushed a commit that referenced this pull request Jun 29, 2022
@Geoffrey-Pliez
Copy link
Contributor

Hello,

I did a test with his changes and it works very well but I have a problem in the build because my component is displayed several times.
Do you have the same?

my-counter in framework-lit example has this behavior.
I think that with each refresh, a new version of the component is added.

Thanks

SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
…ithastro#3766)

* fix: don't throw an error when the lit renderer doesn't provide a clientEntrypoint

* updating the framework-lit example to match new behavior

* fix: updating the playground example to latest lit syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: component has a client:visible directive, but no client entrypoint was provided by @astrojs/lit
3 participants