Restyle error messages #2902
Merged
Restyle error messages #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1245654 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
FredKSchott
force-pushed
the
style-error-messages
branch
5 times, most recently
from
eb19f31 to
b8affec
Compare
FredKSchott
force-pushed
the
style-error-messages
branch
2 times, most recently
from
a9d755f to
1f1cd36
Compare
FredKSchott
force-pushed
the
style-error-messages
branch
from
1f1cd36 to
7824c03
Compare
natemoo-re
approved these changes
Mar 28, 2022
bholmesdev
reviewed
Mar 28, 2022
| const result = await callEndpoint(mod as unknown as EndpointHandler, options); | ||
|
|
||
| if (result.type === 'response') { | ||
| throw new Error(`Returning a Response from an endpoint is not supported in SSG mode.`); |
There was a problem hiding this comment.
I wish I came up with this! but it was just moved from elsewhere. You probably have @matthewp to thank :)
Co-authored-by: Ben Holmes <[email protected]>
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* clean up error logging in astro * update from ben feedback * Update packages/astro/src/core/build/generate.ts Co-authored-by: Ben Holmes <[email protected]> Co-authored-by: Ben Holmes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Screenshots
Build (with metadata)
Dev (with metadata)
Without metadata
Testing
Docs