New Markdown API #2862
Merged
New Markdown API #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 725c367 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
FredKSchott
force-pushed
the
deferred-markdown
branch
from
44b8ee6 to
8fb2b4a
Compare
FredKSchott
force-pushed
the
deferred-markdown
branch
from
8fb2b4a to
1a6ba74
Compare
bholmesdev
reviewed
Mar 23, 2022
FredKSchott
force-pushed
the
deferred-markdown
branch
from
1a6ba74 to
413e416
Compare
natemoo-re
reviewed
Mar 24, 2022
|
Marking as a draft so that no one thinks to merge this for v0.25 :) Will re-mark as ready to merge starting on Monday! |
FredKSchott
force-pushed
the
deferred-markdown
branch
from
413e416 to
267464b
Compare
Merged
FredKSchott
force-pushed
the
deferred-markdown
branch
from
267464b to
e1c40dd
Compare
FredKSchott
force-pushed
the
deferred-markdown
branch
from
e1c40dd to
ce9fd52
Compare
FredKSchott
force-pushed
the
deferred-markdown
branch
from
ce9fd52 to
089fb09
Compare
FredKSchott
force-pushed
the
deferred-markdown
branch
from
8a11d49 to
c07d2ee
Compare
FredKSchott
commented
Mar 28, 2022
| @@ -1,6 +1,6 @@ | |||
| /// <reference types="vite/client" /> | |||
|
|
|||
| type Astro = import('./dist/types/@types/astro').AstroGlobal; | |||
| type Astro = import('astro').AstroGlobal; | |||
There was a problem hiding this comment.
confirmed this continues to work in installed dependencies, but now it also works in our monorepo
natemoo-re
approved these changes
Mar 28, 2022
FredKSchott
force-pushed
the
deferred-markdown
branch
from
c07d2ee to
0b23aac
Compare
natemoo-re
approved these changes
Mar 28, 2022
Merged
1 task
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Implement new markdown plugin with deferred markdown rendering * feat: switch from `getContent()` fn to `<Content />` API * update types * Update packages/astro/src/@types/astro.ts Co-authored-by: Nate Moore <[email protected]> * update types * Create forty-coins-attend.md Co-authored-by: Nate Moore <[email protected]> Co-authored-by: Nate Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs