fix(cloudflare): respect remoteBindings during prerender build#16707
Merged
matthewp merged 2 commits intoMay 12, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 5eb0c55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: integration
helio-cf
commented
May 12, 2026
Comment on lines
+87
to
+93
| plugins: [ | ||
| cfVitePlugin({ | ||
| ...cloudflareOptions, | ||
| ...cfPluginConfig, | ||
| viteEnvironment: { name: 'prerender' }, | ||
| }), | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
im a bit anxious still about cfPluginConfig, will this ever include its own remoteBindings boolean that could override cloudflareOptions ?
matthewp
approved these changes
May 12, 2026
Merged
This was referenced May 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16705
Fixes
remoteBindings: falsebeing ignored duringastro build. The Cloudflare prerenderer's internal Vite preview server now receives the user's adapter options, so remote-flagged bindings (e.g. a D1 database withremote: trueinwrangler.toml) are emulated locally during build, matching the existingastro devbehavior.Changes
The fix is accomplished by forwarding cloudflareOptions (which include remoteBindings setting) to
createCloudflarePrerenderer()