Skip to content

fix(cloudflare): respect remoteBindings during prerender build #16707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewp merged 2 commits into from
May 12, 2026
+15 −1
Merged

fix(cloudflare): respect remoteBindings during prerender build #16707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b10c2f
fix(cloudflare): respect remoteBindings during prerender build
helio-cf May 12, 2026
5eb0c55
Merge branch 'main' into fix/cloudflare-prerender-remote-bindings
helio-cf May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cloudflare-prerender-remote-bindings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/cloudflare': patch
---

Fixes `remoteBindings: false` being ignored during `astro build`. The Cloudflare prerenderer's internal Vite preview server now receives the user's adapter options, so remote-flagged bindings (e.g. a D1 database with `remote: true` in `wrangler.toml`) are emulated locally during build, matching the existing `astro dev` behavior.
1 change: 1 addition & 0 deletions packages/integrations/cloudflare/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ export default function createIntegration({
if (prerenderEnvironment === 'workerd') {
setPrerenderer(
createCloudflarePrerenderer({
cloudflareOptions,
root: _config.root,
serverDir: _config.build.server,
clientDir: _config.build.client,
Expand Down
10 changes: 9 additions & 1 deletion packages/integrations/cloudflare/src/prerenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
} from './utils/prerender-constants.js';

interface CloudflarePrerendererOptions {
cloudflareOptions: Partial<PluginConfig>;
root: AstroConfig['root'];
serverDir: AstroConfig['build']['server'];
clientDir: AstroConfig['build']['client'];
Expand All @@ -35,6 +36,7 @@ interface CloudflarePrerendererOptions {
* This allows prerendering to happen in the same runtime that will serve the pages.
*/
export function createCloudflarePrerenderer({
cloudflareOptions,
root,
serverDir,
clientDir,
Expand Down Expand Up @@ -82,7 +84,13 @@ export function createCloudflarePrerenderer({
port: 0, // Let the OS pick a free port
open: false,
},
plugins: [cfVitePlugin({ ...cfPluginConfig, viteEnvironment: { name: 'prerender' } })],
plugins: [
cfVitePlugin({
...cloudflareOptions,
...cfPluginConfig,
viteEnvironment: { name: 'prerender' },
}),
],
Comment on lines +87 to +93
Copy link
Copy Markdown
Contributor Author

@helio-cf helio-cf May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im a bit anxious still about cfPluginConfig, will this ever include its own remoteBindings boolean that could override cloudflareOptions ?

});

const address = previewServer.httpServer.address();
Expand Down
Loading