fix(vercel): Fix ISR path rewrite to prevent 404#16079
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 71ae513 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: integration
Princesseuh
approved these changes
Mar 25, 2026
Contributor
|
@Princesseuh, When can we expect this to be released? This currently blocks our upgrade to Astro 6, which we would like to do. Thanks for fixing this. |
Member
|
Tomorrow most likely, with the rest of 6.1. |
Merged
Contributor
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix a bug which prevented pages from being served by ISR by the vercel adapter.
This PR introduced a bug with the vercel adaptor which made any route served by ISR result in a 404. This is due to an intricacy with how vercel ISR works, in that we need to change the request path when serving an ISR path. This was noticed by a commenter in the PR.
Testing
No additional test cases added. Manual e2e tests performed on a test vercel project (note this includes other code from another PR I am working on, but the upshot is that it is a ISR page, which does not 404, as opposed to an earlier deployment without this fix which does 404).
Docs
No docs needed as a bug fix for internal adapter logic