Skip to content

Require trusted secret for path overrides#15959

Merged
matthewp merged 3 commits into
mainfrom
fix/vercel-path-override-secret-gate
Mar 19, 2026
Merged

Require trusted secret for path overrides#15959
matthewp merged 3 commits into
mainfrom
fix/vercel-path-override-secret-gate

Conversation

@matthewp
Copy link
Copy Markdown
Contributor

@matthewp matthewp commented Mar 17, 2026

Changes

  • Require the middleware secret when resolving serverless path overrides.
  • Remove unused ISR secret plumbing from the Vercel serverless entrypoint.
  • Add regression tests to ensure untrusted override query/header values are ignored.

Testing

  • New tests added

Docs

  • No docs update needed; this is an internal Vercel adapter bug fix.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 17, 2026

🦋 Changeset detected

Latest commit: 4102072

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: integration Related to any renderer integration (scope) label Mar 17, 2026
@matthewp matthewp changed the title fix(vercel): require trusted secret for path overrides Require trusted secret for path overrides Mar 17, 2026
Copy link
Copy Markdown
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no issue, so maybe give us a context of what we're fixing, so we know what we're reviewing

Comment thread .changeset/short-cycles-fail.md
@matthewp matthewp merged commit 335a204 into main Mar 19, 2026
21 checks passed
@matthewp matthewp deleted the fix/vercel-path-override-secret-gate branch March 19, 2026 13:24
@astrobot-houston astrobot-houston mentioned this pull request Mar 19, 2026
@KurtGokhan
Copy link
Copy Markdown
Contributor

I think this might have caused a regression as I am getting 404: Not found Path: /_isr errors with this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants