Skip to content

feat: stabilise CSP#14946

Merged
ematipico merged 13 commits intonextfrom
feat/stable-csp
Dec 12, 2025
Merged

feat: stabilise CSP#14946
ematipico merged 13 commits intonextfrom
feat/stable-csp

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Dec 2, 2025

Changes

Testing

Tests should pass

Docs

withastro/docs#12859

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2025

🦋 Changeset detected

Latest commit: 4afe02c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Dec 2, 2025
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Dec 2, 2025
@ematipico ematipico self-assigned this Dec 3, 2025
@florian-lefebvre florian-lefebvre added this to the v6.0.0 milestone Dec 4, 2025
@sarah11918
Copy link
Member

sarah11918 commented Dec 8, 2025

Just a quick note re: the eventual accompanying docs PR to make after discussion:

  • You do not need to make a separate CSP page in docs (at least, at this time) when you delete the experimental CSP page.

  • The existing content at https://docs.astro.build/en/reference/experimental-flags/csp/ is reference entry material that can move to either Configuration Reference (configuration-reference.mdx) or the Render Context (api-reference.mdx) page. Try to adapt the runtime examples to our current format, including showing realistic examples of using both the Astro object and the context object.

  • To keep our v6 docs branch PR fully updated with working links, the config reference content should be added directly into the v6 branch /en/reference/configuration-reference.mdx file (even though you will be warned that you shouldn't) in addition to preparing the JSDoc for config docs in this PR. At this stage, we don't have a great way of pulling in the JSDoc to this branch just yet, so we duplicate content for internal consistency and then our normal process will alert us of any discrepancies we need to tidy up later. This can also make it easier to finalize/polish the new docs where we can see them in place, then it can be easier to replicate that in the config types file.

@ematipico ematipico marked this pull request as ready for review December 8, 2025 13:33
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! This will need a changeset

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review of changeset (and error message looks good) - I don't know if you want this same message for all the adapter minors, too, but for stabilizing flags, we've been just mentioning the removed flag, its replacement, and linking to the experimental flags section of the upgrade guide (as suggested below).

I'll review the content of the config docs in the docs PR to start (since that's easier 😄 ) and whatever we finalize there, we can update here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

⚠️ Package Trust Level Decreased

Caution

Decreased trust levels may indicate a higher risk of supply chain attacks. Please review these changes carefully.

📦 Package 🔒 Before 🔓 After
@cloudflare/unenv-preset trusted-with-provenance none
workerd trusted-with-provenance none
undici provenance none
miniflare trusted-with-provenance none
youch provenance none
@cloudflare/workerd-darwin-64 trusted-with-provenance none
@cloudflare/workerd-darwin-arm64 trusted-with-provenance none
@cloudflare/workerd-linux-64 trusted-with-provenance none
@cloudflare/workerd-linux-arm64 trusted-with-provenance none
@cloudflare/workerd-windows-64 trusted-with-provenance none
wrangler trusted-with-provenance none

@ematipico ematipico merged commit 95c40f7 into next Dec 12, 2025
23 checks passed
@ematipico ematipico deleted the feat/stable-csp branch December 12, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants