-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: stabilize CSP #12859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stabilize CSP #12859
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Thanks @ematipico ! We'll also need to add something to the v6 upgrade guide at https://deploy-preview-12322--astro-docs-2.netlify.app/en/guides/upgrade-to/v6/#experimental-flags This flag can be added to the block of all the flags being removed, then probably just a very similar entry under https://deploy-preview-12322--astro-docs-2.netlify.app/en/guides/upgrade-to/v6/#experimental-features-now-stable to the existing
|
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @ematipico !
I think the bulk of the work is going to be figuring out how to make the config reference stuff as concise as possible, and I've left a bunch of suggestions about doing that.
Also, the experimental-flags/csp.mdx page can be completely deleted, and should be removed from the Astro sidebar
|
Just noting that some of the failed links are on the experimental CSP page (which will be deleted) and I've suggested fixes to the others above. So, those should end up OK! |
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review is called "Death by a thousand indentations" 😆
I am going to commit all of these that are just fixing indentation, and let you review the rest so that it's not quite so overwhelming, @ematipico . But, this looks fantastic! I hope you're happy with it!
Co-authored-by: Sarah Rainsberger <[email protected]>
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two suggestions to fix the broken links (don't mind Github diff, the lines are not blank 😅 ) and another one to fix the spacing between an API block and the description.
Otherwise, this looks great!
|
OK, with any luck, this all just works! I removed the experimental pages and deleted its entry from the sidebar. Now we find out if other files were linking here! 😅 |
|
I have added a note for translators to the description: In some of the adapter pages, the link text may also need updating to remove the word "experimental" where it exists. I have only done English and French in this PR, but we have zh-cn, ja, and ko pages to check. These can be done on this PR, or on the v6 branch itself if this PR is already merged. (Feel free to make direct commits to v6 for this if needed.) Also, since we don't have cc @liruifengv , @jp-knj , and @jsparkdev |
Description (required)
This PR stabilise the CSP APIs.
Moves the CSP APIs and configuration in the proper sections.
I only moved the content, I didn't update the current wording.
Also, I took the liberty to refactor the security section because it became quite lengthy, so I thought it required a proper header now.
For Astro version:
6.0. See astro PR #14946 and JSDoc in PR #15007Note for translators:
In some of the adapter pages, the link text may also need updating to remove the word "experimental" where it exists. I have only done English and French in this PR, but we have
zh-cn,ja, andkopages to check. These can be done on this PR, or on the v6 branch itself if this PR is already merged. (Feel free to make direct commits to v6 for this if needed.)cc @liruifengv , @jp-knj , and @jsparkdev