Update next #14530
Merged
Update next #14530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(security): require allowedDomains config for X-Forwarded-Host validation Fixes X-Forwarded-Host header injection vulnerability by requiring explicit allowedDomains configuration. When not configured, X-Forwarded-Host headers are ignored to prevent manipulation of Astro.url by malicious requests. - Add security.allowedDomains configuration using RemotePattern format - Validate X-Forwarded-Host against allowedDomains patterns in both App and NodeApp - Ignore untrusted headers when no allowedDomains configured (secure by default) - Update tests to verify security behavior with and without configuration * Address PR review feedback on allowedDomains implementation - Remove pathname field from allowedDomains schema (not applicable to host headers) - Clarify documentation that protocol, hostname, and port are all validated if provided - Add test demonstrating port validation behavior when port not specified in pattern * add changeset * make it a patch * explain the breaking change * Update secure-forwarded-host-validation.md
* Fix failing x-forwarded-host tests * allow setting the manifest * fix other test and add changeset * fix another thing * h4 * set it back * replace heading with bold since CI complains
* [ci] release * Skip yarn test that fails with unpublished dependencies The yarn test packs astro and attempts to install it, which fails when workspace dependencies like @astrojs/internal-helpers have been bumped but not yet published to npm. Skip this test to allow the release to proceed. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Phillips <[email protected]>
…enabled (#14235) * add onPageLoad call to tap strategy * add changeset * add tests * format * rename test * fix tests * remove onPageLoad, add event listener directly on the document
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- Make getAllowedDomains() call optional with fallback to empty array - Update peer dependency to require astro@^5.14.3 - Fixes #14513
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
) Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
🦋 Changeset detectedLatest commit: 01b63bb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
feat: markdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
N/A
Docs
N/A