-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update content.d.ts astro/loader => loaders #14525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix typo in import
🦋 Changeset detectedLatest commit: bc8019b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey good catch thanks! Can you add a patch changeset? |
|
@florian-lefebvre done, as a patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@florian-lefebvre this was one of several issues that came up when I added |
|
I honestly don't know, you can probably open an issue for these errors 👍 |
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`5.14.4` -> `5.14.5`](https://renovatebot.com/diffs/npm/astro/5.14.4/5.14.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>withastro/astro (astro)</summary> ### [`v5.14.5`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#5145) [Compare Source](https://github.com/withastro/astro/compare/[email protected]@5.14.5) ##### Patch Changes - [#​14525](withastro/astro#14525) [`4f55781`](withastro/astro@4f55781) Thanks [@​penx](https://github.com/penx)! - Fixes `defineLiveCollection()` types - [#​14441](withastro/astro#14441) [`62ec8ea`](withastro/astro@62ec8ea) Thanks [@​upsuper](https://github.com/upsuper)! - Updates redirect handling to be consistent across `static` and `server` output, aligning with the behavior of other adapters. Previously, the Node.js adapter used default HTML files with meta refresh tags when in `static` output. This often resulted in an extra flash of the page on redirect, while also not applying the proper status code for redirections. It's also likely less friendly to search engines. This update ensures that configured redirects are always handled as HTTP redirects regardless of output mode, and the default HTML files for the redirects are no longer generated in `static` output. It makes the Node.js adapter more consistent with the other official adapters. No change to your project is required to take advantage of this new adapter functionality. It is not expected to cause any breaking changes. However, if you relied on the previous redirecting behavior, you may need to handle your redirects differently now. Otherwise you should notice smoother redirects, with more accurate HTTP status codes, and may potentially see some SEO gains. - [#​14506](withastro/astro#14506) [`ec3cbe1`](withastro/astro@ec3cbe1) Thanks [@​abdo-spices](https://github.com/abdo-spices)! - Updates the `<Font />` component so that preload links are generated after the style tag, as recommended by capo.js </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45OS4xMSIsInVwZGF0ZWRJblZlciI6IjQxLjk5LjExIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://code.richardbanks.dev/richard/astro-loader-youtube/pulls/18 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

Changes
Fixed a typo in import
pnpm changeset.Testing
I saw a TypeScript error locally when looking at node_modules/astro/types/content.d.ts
This package doesn't seem to exist, and the import seems to be in
astro/loadersso opening a quick PR to address.No further tests done as I'm unfamiliar with Astro internals.
Docs
I don't think any docs are needed.