Skip to content

Conversation

@penx
Copy link
Contributor

@penx penx commented Oct 13, 2025

Changes

Fixed a typo in import

  • Don't forget a changeset! Run pnpm changeset.

Testing

I saw a TypeScript error locally when looking at node_modules/astro/types/content.d.ts

	export function defineLiveCollection<
		L extends import('astro/loader').LiveLoader,
		S extends import('astro/content/config').BaseSchema | undefined = undefined,
	>(
		config: import('astro/content/config').LiveCollectionConfig<L, S>,
	): import('astro/content/config').LiveCollectionConfig<L, S>;

Cannot find module 'astro/loader' or its corresponding type declarations

This package doesn't seem to exist, and the import seems to be in astro/loaders so opening a quick PR to address.

No further tests done as I'm unfamiliar with Astro internals.

Docs

I don't think any docs are needed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2025

🦋 Changeset detected

Latest commit: bc8019b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 13, 2025
@florian-lefebvre
Copy link
Member

Hey good catch thanks! Can you add a patch changeset?

@penx
Copy link
Contributor Author

penx commented Oct 13, 2025

@florian-lefebvre done, as a patch

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@penx
Copy link
Contributor Author

penx commented Oct 13, 2025

@florian-lefebvre this was one of several issues that came up when I added "skipLibCheck": false, to my tsconfig. Mostly they were conflicts between .astro/content.d.ts and node_modules/astro/types/content.d.ts. Do you know if this should work? I'll retry once this is in :)

@penx
Copy link
Contributor Author

penx commented Oct 13, 2025

Screenshot 2025-10-13 at 15 19 39

@florian-lefebvre
Copy link
Member

florian-lefebvre commented Oct 13, 2025

I honestly don't know, you can probably open an issue for these errors 👍

@florian-lefebvre florian-lefebvre merged commit 4f55781 into withastro:main Oct 13, 2025
20 checks passed
@penx penx deleted the patch-1 branch October 13, 2025 15:02
@astrobot-houston astrobot-houston mentioned this pull request Oct 13, 2025
richardnbanks pushed a commit to richardnbanks/astro-loader-youtube that referenced this pull request Oct 15, 2025
This PR contains the following updates:

| Package | Change | Age | Confidence |
|---|---|---|---|
| [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`5.14.4` -> `5.14.5`](https://renovatebot.com/diffs/npm/astro/5.14.4/5.14.5) | [![age](https://developer.mend.io/api/mc/badges/age/npm/astro/5.14.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/astro/5.14.4/5.14.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>withastro/astro (astro)</summary>

### [`v5.14.5`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#5145)

[Compare Source](https://github.com/withastro/astro/compare/[email protected]@5.14.5)

##### Patch Changes

- [#&#8203;14525](withastro/astro#14525) [`4f55781`](withastro/astro@4f55781) Thanks [@&#8203;penx](https://github.com/penx)! - Fixes `defineLiveCollection()` types

- [#&#8203;14441](withastro/astro#14441) [`62ec8ea`](withastro/astro@62ec8ea) Thanks [@&#8203;upsuper](https://github.com/upsuper)! - Updates redirect handling to be consistent across `static` and `server` output, aligning with the behavior of other adapters.

  Previously, the Node.js adapter used default HTML files with meta refresh tags when in `static` output. This often resulted in an extra flash of the page on redirect, while also not applying the proper status code for redirections. It's also likely less friendly to search engines.

  This update ensures that configured redirects are always handled as HTTP redirects regardless of output mode, and the default HTML files for the redirects are no longer generated in `static` output. It makes the Node.js adapter more consistent with the other official adapters.

  No change to your project is required to take advantage of this new adapter functionality. It is not expected to cause any breaking changes. However, if you relied on the previous redirecting behavior, you may need to handle your redirects differently now. Otherwise you should notice smoother redirects, with more accurate HTTP status codes, and may potentially see some SEO gains.

- [#&#8203;14506](withastro/astro#14506) [`ec3cbe1`](withastro/astro@ec3cbe1) Thanks [@&#8203;abdo-spices](https://github.com/abdo-spices)! - Updates the `<Font />` component so that preload links are generated after the style tag, as recommended by capo.js

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45OS4xMSIsInVwZGF0ZWRJblZlciI6IjQxLjk5LjExIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://code.richardbanks.dev/richard/astro-loader-youtube/pulls/18
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants