Skip to content

Comments

Fix i18n current locale#12839

Merged
ematipico merged 9 commits intowithastro:mainfrom
mtwilliams-code:fix-i18n-currentLocale
Jan 10, 2025
Merged

Fix i18n current locale#12839
ematipico merged 9 commits intowithastro:mainfrom
mtwilliams-code:fix-i18n-currentLocale

Conversation

@mtwilliams-code
Copy link
Contributor

@mtwilliams-code mtwilliams-code commented Dec 27, 2024

Changes

Testing

Adds similar logic to computeCurrentLocale as was used in #12709 to handle SSR manifests with fallback routes.
Welcome feedback from a maintainer on whether there may be a more elegant solution to solve both of these - I dont have enough background on the decision process behind having such different manifests and i18n implementation between dev/SSR/SSG.

Docs

Just corrects a bug and inconsistent behavior across modes. No new docs needed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2024

🦋 Changeset detected

Latest commit: bab3349

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 27, 2024
@mtwilliams-code mtwilliams-code marked this pull request as ready for review December 27, 2024 20:15
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #12839 will not alter performance

Comparing mtwilliams-code:fix-i18n-currentLocale (bab3349) with main (4b7a2ce)

Summary

✅ 6 untouched benchmarks

@bluwy bluwy linked an issue Jan 8, 2025 that may be closed by this pull request
1 task
@ematipico ematipico merged commit 57be349 into withastro:main Jan 10, 2025
16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Astro.currentLocale doesn't work correctly in SSR with fallback

2 participants