Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace start command #12194

Closed
wants to merge 14 commits into from
Closed

Replace start command #12194

wants to merge 14 commits into from

Conversation

TheOtterlord
Copy link
Member

@TheOtterlord TheOtterlord commented Oct 11, 2024 •
edited
Loading

Changes

  • Replace start command from templates with echo 'Warning: The startscript is no longer included in Astro templates. Please usedev to start the development server.'

Testing

N/A

Docs

withastro/docs#9646

@TheOtterlord TheOtterlord mentioned this pull request Oct 11, 2024
Open
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0e3063e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: example Related to an example package (scope) pkg: astro Related to the core `astro` package (scope) labels Oct 11, 2024
TheOtterlord and others added 6 commits October 11, 2024 14:33
@TheOtterlord
Revert: Replace start command
fb19e87
@matthewp
Ensure router only targets scripts for execution (#12177)
a4ffbfa 
* Ensure router only targets scripts for execution

* Add a test

* Move the test up to the file that's testing

* remove extra prop

* just see if tests pass

* use local file

* smaller file

* use getElementsByTagName again
@ematipico @bluwy
fix(routing): actions should redirect the original pathname (#12173)
2d10de5 
* fix(routing): actions should redirect the original pathname

* decode header to avoid index out of bounds

* fix e2e test

* Update packages/astro/e2e/actions-blog.test.js

Co-authored-by: Bjorn Lu <[email protected]>

---------

Co-authored-by: Bjorn Lu <[email protected]>
@ematipico @astrobot-houston
[ci] format
58e22bd
@bluwy
Remove some examples (#12196)
fd367b5
@TheOtterlord
Merge main into remove-start
0e3063e
@matthewp
Copy link
Contributor

I think this should be against next and not main. Let's fix this in 5.0

@TheOtterlord TheOtterlord changed the base branch from main to next October 11, 2024 17:19
@TheOtterlord
Copy link
Member Author

Making a followup PR to prevent merging main into next

@TheOtterlord TheOtterlord mentioned this pull request Oct 11, 2024
Open
@TheOtterlord
Copy link
Member Author

#12200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheOtterlord @matthewp @bluwy @Terfno @ematipico