Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace start command #12194

Closed
wants to merge 14 commits into from
Closed

Replace start command #12194

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9988dd6
Improve default template download speed (#12154)
bluwy Oct 10, 2024
a55ce29
Check permissions for workflows (#12181)
bluwy Oct 10, 2024
1f93fca
Fix biome lint warning (#12187)
bluwy Oct 11, 2024
36b7e8c
Remove start command
TheOtterlord Oct 11, 2024
0dab9d4
Replace start command
TheOtterlord Oct 11, 2024
49c4f64
Ensure that the generated package.json and tsconfig.json end with a n…
Terfno Oct 11, 2024
2f5b28e
Use p-queue instead of fastq (#12189)
bluwy Oct 11, 2024
411af55
[ci] format
bluwy Oct 11, 2024
fb19e87
Revert: Replace start command
TheOtterlord Oct 11, 2024
a4ffbfa
Ensure router only targets scripts for execution (#12177)
matthewp Oct 11, 2024
2d10de5
fix(routing): actions should redirect the original pathname (#12173)
ematipico Oct 11, 2024
58e22bd
[ci] format
ematipico Oct 11, 2024
fd367b5
Remove some examples (#12196)
bluwy Oct 11, 2024
0e3063e
Merge main into remove-start
TheOtterlord Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/curvy-bikes-sing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-astro': minor
---

Improves default template download speed by downloading from a branch containing the template only
7 changes: 7 additions & 0 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ jobs:
PR-BENCH: ${{ steps.benchmark-pr.outputs.BENCH_RESULT }}
MAIN-BENCH: ${{ steps.benchmark-main.outputs.BENCH_RESULT }}
steps:
- name: Check if user has write access
uses: lannonbr/[email protected]
with:
permission: write
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# https://github.com/actions/checkout/issues/331#issuecomment-1438220926
- uses: actions/checkout@v4
with:
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/preview-comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Check if user has write access
uses: lannonbr/[email protected]
with:
permission: write
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- run: |
gh issue edit ${{ github.event.issue.number }} --add-label "pr: preview" --repo ${{ github.repository }}
env:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/snapshot-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ jobs:
issues: write
pull-requests: write
steps:
- name: "Check if user has write access"
uses: "lannonbr/[email protected]"
- name: Check if user has write access
uses: lannonbr/[email protected]
with:
permission: "write"
permission: write
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/sync-examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,13 @@ jobs:
# We only do sync if there are no changesets, so we don't accidentally allow users
# to clone examples that may rely on unreleased code

- name: Sync from main branch to latest branch
- name: Sync from main branch to latest and examples/* branches
if: steps.detect.outputs.has-changesets == 'false' && github.ref == 'refs/heads/main'
uses: bluwy/auto-branch-sync-action@v1
with:
map: / -> latest
map: |
/ -> latest
/examples/* -> examples/*
skip-unchanged-check: ${{ inputs.skip-unchanged-check == true }}
dry-run: ${{ inputs.dry-run == true }}

Expand Down
2 changes: 1 addition & 1 deletion examples/basics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
TheOtterlord marked this conversation as resolved.
Show resolved Hide resolved
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
2 changes: 1 addition & 1 deletion examples/blog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
2 changes: 1 addition & 1 deletion examples/container-with-vitest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro",
Expand Down
2 changes: 1 addition & 1 deletion examples/framework-alpine/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
2 changes: 1 addition & 1 deletion examples/framework-lit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
2 changes: 1 addition & 1 deletion examples/framework-multiple/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
2 changes: 1 addition & 1 deletion examples/framework-preact/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
2 changes: 1 addition & 1 deletion examples/framework-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
2 changes: 1 addition & 1 deletion examples/framework-solid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
2 changes: 1 addition & 1 deletion examples/framework-svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
2 changes: 1 addition & 1 deletion examples/framework-vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
4 changes: 3 additions & 1 deletion examples/hackernews/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# build output
dist/
.output/
# generated types
.astro/

Expand All @@ -20,3 +19,6 @@ pnpm-debug.log*

# macOS-specific files
.DS_Store

# jetbrains setting folder
.idea/
2 changes: 1 addition & 1 deletion examples/hackernews/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
24 changes: 24 additions & 0 deletions examples/integration/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# build output
dist/
# generated types
.astro/

# dependencies
node_modules/

# logs
npm-debug.log*
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*


# environment variables
.env
.env.production

# macOS-specific files
.DS_Store

# jetbrains setting folder
.idea/
24 changes: 24 additions & 0 deletions examples/middleware/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# build output
dist/
# generated types
.astro/

# dependencies
node_modules/

# logs
npm-debug.log*
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*


# environment variables
.env
.env.production

# macOS-specific files
.DS_Store

# jetbrains setting folder
.idea/
2 changes: 1 addition & 1 deletion examples/middleware/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro",
Expand Down
2 changes: 1 addition & 1 deletion examples/minimal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
2 changes: 1 addition & 1 deletion examples/non-html-pages/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
2 changes: 1 addition & 1 deletion examples/portfolio/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
24 changes: 24 additions & 0 deletions examples/server-islands/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# build output
dist/
# generated types
.astro/

# dependencies
node_modules/

# logs
npm-debug.log*
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*


# environment variables
.env
.env.production

# macOS-specific files
.DS_Store

# jetbrains setting folder
.idea/
2 changes: 1 addition & 1 deletion examples/server-islands/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
24 changes: 24 additions & 0 deletions examples/ssr/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# build output
dist/
# generated types
.astro/

# dependencies
node_modules/

# logs
npm-debug.log*
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*


# environment variables
.env
.env.production

# macOS-specific files
.DS_Store

# jetbrains setting folder
.idea/
2 changes: 1 addition & 1 deletion examples/ssr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro",
Expand Down
24 changes: 24 additions & 0 deletions examples/starlog/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# build output
dist/
# generated types
.astro/

# dependencies
node_modules/

# logs
npm-debug.log*
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*


# environment variables
.env
.env.production

# macOS-specific files
.DS_Store

# jetbrains setting folder
.idea/
2 changes: 1 addition & 1 deletion examples/starlog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": "0.0.1",
"scripts": {
"dev": "astro dev",
"start": "astro dev",
"start": "echo 'Warning: The `start` script is no longer included in Astro templates. Please use `dev` to start the development server.'",
"build": "astro build",
"preview": "astro preview",
"astro": "astro"
Expand Down
24 changes: 24 additions & 0 deletions examples/view-transitions/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# build output
dist/
# generated types
.astro/

# dependencies
node_modules/

# logs
npm-debug.log*
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*


# environment variables
.env
.env.production

# macOS-specific files
.DS_Store

# jetbrains setting folder
.idea/
Loading
Loading