Skip to content

Fix v3 leak in get-conversation endpoints#2992

Merged
pcapriotti merged 7 commits intodevelopfrom
pcapriotti/get-conversation-v3-leak
Jan 18, 2023
Merged

Fix v3 leak in get-conversation endpoints#2992
pcapriotti merged 7 commits intodevelopfrom
pcapriotti/get-conversation-v3-leak

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jan 16, 2023

https://wearezeta.atlassian.net/browse/FS-1312

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti temporarily deployed to cachix January 16, 2023 15:23 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 16, 2023 15:23 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 16, 2023
@pcapriotti pcapriotti temporarily deployed to cachix January 16, 2023 15:42 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 16, 2023 15:42 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 16, 2023 15:59 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 16, 2023 15:59 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic self-requested a review January 17, 2023 09:18
@pcapriotti pcapriotti temporarily deployed to cachix January 17, 2023 09:58 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 17, 2023 09:58 — with GitHub Actions Inactive
elland
elland reviewed Jan 17, 2023
View reviewed changes
services/galley/test/integration/Main.hs
[ testCase "sitemap" $
assertEqual
"inconcistent sitemap"
"inconsistent sitemap"
Copy link
Contributor

@elland elland Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@pcapriotti pcapriotti merged commit c21e6a3 into develop Jan 18, 2023
@pcapriotti pcapriotti deleted the pcapriotti/get-conversation-v3-leak branch January 18, 2023 09:03
@zebot zebot mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanwire stefanwire stefanwire approved these changes

@mdimjasevic mdimjasevic Awaiting requested review from mdimjasevic

+1 more reviewer

@elland elland elland approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pcapriotti @elland @stefanwire @zebot

Comments