Skip to content

Comments

[FS-1336] Leaving subconversations#2969

Merged
pcapriotti merged 12 commits intomlsfrom
pcapriotti/subconv-leave
Feb 3, 2023
Merged

[FS-1336] Leaving subconversations#2969
pcapriotti merged 12 commits intomlsfrom
pcapriotti/subconv-leave

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jan 10, 2023 •
edited
Loading

https://wearezeta.atlassian.net/browse/FS-1336

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti temporarily deployed to cachix January 10, 2023 10:25 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 10, 2023 10:25 — with GitHub Actions Inactive
@pcapriotti pcapriotti changed the base branch from develop to mls January 10, 2023 10:26
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 10, 2023
elland
elland reviewed Jan 11, 2023
View reviewed changes
@pcapriotti pcapriotti temporarily deployed to cachix January 11, 2023 15:24 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 11, 2023 15:24 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 11, 2023 16:07 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 11, 2023 16:07 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic mentioned this pull request Jan 11, 2023
Merged
2 tasks
@elland elland changed the title Leaving subconversations [FS-1336] Leaving subconversations Jan 12, 2023
@pcapriotti pcapriotti force-pushed the pcapriotti/subconv-leave branch from a24a9e1 to 336aa24 Compare January 12, 2023 09:56
@pcapriotti pcapriotti temporarily deployed to cachix January 12, 2023 09:56 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 12, 2023 09:56 — with GitHub Actions Inactive
mdimjasevic
mdimjasevic reviewed Jan 12, 2023
View reviewed changes
@pcapriotti pcapriotti temporarily deployed to cachix January 12, 2023 15:06 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 12, 2023 15:06 — with GitHub Actions Inactive
@pcapriotti pcapriotti force-pushed the pcapriotti/subconv-leave branch from 24076c0 to 8471e4b Compare January 13, 2023 10:03
@pcapriotti pcapriotti temporarily deployed to cachix January 13, 2023 10:03 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 13, 2023 10:03 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 13, 2023 10:07 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 13, 2023 10:07 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 13, 2023 12:33 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 13, 2023 12:33 — with GitHub Actions Inactive
@pcapriotti pcapriotti force-pushed the pcapriotti/subconv-leave branch from a0e6ee3 to a54221c Compare January 16, 2023 10:17
@pcapriotti pcapriotti temporarily deployed to cachix January 16, 2023 16:08 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix January 16, 2023 16:08 — with GitHub Actions Inactive
@pcapriotti pcapriotti force-pushed the pcapriotti/subconv-leave branch from 17c58fd to a9d24e7 Compare February 1, 2023 10:38
@pcapriotti
Small refactoring
0bb760a 
 - Remove utility function `convsub` and inline its uses.
 - `createSubConv` now returns a `Qualified ConvOrSubId`.
@pcapriotti
Test leaving a subconversation
4eecd89
@pcapriotti
Test leaving a subconversation as a non-member
ff327c7
@pcapriotti
WIP
8fdb075
@pcapriotti pcapriotti force-pushed the pcapriotti/subconv-leave branch from a9d24e7 to 40cffd3 Compare February 1, 2023 14:57
@pcapriotti pcapriotti force-pushed the pcapriotti/subconv-leave branch from 40cffd3 to 167e8d4 Compare February 1, 2023 14:59
@pcapriotti pcapriotti marked this pull request as ready for review February 2, 2023 12:34
@smatting smatting self-requested a review February 3, 2023 09:48
@pcapriotti pcapriotti merged commit 27ef3df into mls Feb 3, 2023
@pcapriotti pcapriotti deleted the pcapriotti/subconv-leave branch February 3, 2023 13:11
smatting
smatting reviewed Feb 3, 2023
View reviewed changes
services/galley/test/integration/API/MLS.hs

msgs <-
WS.assertMatchN (5 # WS.Second) wss $
wsAssertBackendRemoveProposal charlie qcnv charlie1KP
Copy link
Contributor

@smatting smatting Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably assert that the event is for qsub here

@mdimjasevic mdimjasevic mentioned this pull request Feb 10, 2023
Closed
2 tasks
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smatting smatting smatting approved these changes

+2 more reviewers

@elland elland elland left review comments

@mdimjasevic mdimjasevic mdimjasevic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pcapriotti @elland @smatting @mdimjasevic @zebot @stefanwire