[FS-901] Tests for joining subconversation#2974
Conversation
zebot
added
the
ok-to-test
mdimjasevic
force-pushed
the
fs-901/tests-for-joining
branch
from
bee922a to
b4a2a65
Compare
mdimjasevic
changed the base branch from
mls
to
mdimjasevic/subconv-epoch-0-kpref-fix
mdimjasevic
force-pushed
the
fs-901/tests-for-joining
branch
from
b4a2a65 to
dfd5ffc
Compare
mdimjasevic
force-pushed
the
fs-901/tests-for-joining
branch
from
dfd5ffc to
8c1bf38
Compare
mdimjasevic
force-pushed
the
fs-901/tests-for-joining
branch
from
8c1bf38 to
dc2d662
Compare
pcapriotti
force-pushed
the
pcapriotti/subconv-leave
branch
from
24076c0 to
8471e4b
Compare
| CallsFed 'Galley "on-conversation-updated", | ||
| CallsFed 'Galley "on-mls-message-sent", | ||
| CallsFed 'Galley "on-new-remote-conversation", | ||
| CallsFed 'Galley "on-new-remote-conversation" |
There was a problem hiding this comment.
I think I'd avoid adding these calls to the umbrella type 🤔 and instead only add them to the functions that need the constraint.
There was a problem hiding this comment.
I cherry-picked this change from the PR you and Paolo have been working on; I suppose you changed this in the meantime so I'll update it here too.
There was a problem hiding this comment.
I'm not sure. I recall the on-mls-message-sent, and on-conversation-updated being there, but I assumed those were always needed.
There was a problem hiding this comment.
There are three use sites of the HasProposalActionEffects type alias. If I remove CallsFed 'Galley "on-new-remote-conversation" from this type alias, all the three use sites are missing the CallsFed constraint.
|
|
||
| -- FUTUREWORK: remove this check after remote admins are implemented in federation https://wearezeta.atlassian.net/browse/FS-216 | ||
| foldQualified lconv (\_ -> pure ()) (\_ -> throwS @'MLSUnsupportedProposal) qusr | ||
| foldQualified lconvOrSub (\_ -> pure ()) (\_ -> throwS @'MLSUnsupportedProposal) qusr |
There was a problem hiding this comment.
Might be worth it having a different combinator for these cases, like whenLocal and whenRemote, if we're doing that with enough frequency.
| (Epoch 1) | ||
| (pscEpoch finalSub) | ||
|
|
||
| -- FUTUREWORK: implement the following tests |
There was a problem hiding this comment.
I think having these stub tests below feels ripe for both merge conflicts and the assumption of tests existing by their outputs being green instead of yellow or something like that,.
4 participants
Tracked by https://wearezeta.atlassian.net/browse/FS-901. Commit 352e063 that implements proposal execution in subconversations was cherry-picked from PR #2969. Either this PR gets merged with the cherry-picked commit or #2969 gets merged first and then this PR gets rebased.
Checklist
changelog.d