[FS-1336] Extend a test: everyone gets notified about leaving#3073
Closed
mdimjasevic wants to merge 3 commits intomlsfrom
Closed
[FS-1336] Extend a test: everyone gets notified about leaving#3073mdimjasevic wants to merge 3 commits intomlsfrom
mdimjasevic wants to merge 3 commits intomlsfrom
Conversation
zebot
added
the
ok-to-test
mdimjasevic
changed the title
Contributor
Author
|
What is given in the description of the PR should actually not be the desired behavior. The modified test passing (at least it did pass locally; the CI runs are still unreliable) shows it's a bug in the code; the leaver should not get the remove proposal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2969 and an extension to a test for leaving a subconversation where everyone in the subconversation, including the leaver, gets the backend-created remove propsal.
Tracked by https://wearezeta.atlassian.net/browse/FS-1336.
Checklist
changelog.d