Skip to content

Comments

[Polysemy] Effects Around the User Query Effect#2450

Closed
mdimjasevic wants to merge 49 commits intodevelopfrom
polysemy/brig/user-cookie-effects
Closed

[Polysemy] Effects Around the User Query Effect#2450
mdimjasevic wants to merge 49 commits intodevelopfrom
polysemy/brig/user-cookie-effects

Conversation

@mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Jun 2, 2022

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@mdimjasevic mdimjasevic force-pushed the polysemy/brig/user-cookie-effects branch from e334845 to 7781845 Compare June 3, 2022 09:31
@mdimjasevic mdimjasevic temporarily deployed to cachix June 3, 2022 09:31 Inactive
@mdimjasevic mdimjasevic force-pushed the polysemy/brig/user-cookie-effects branch from 7781845 to 6c675ec Compare June 3, 2022 09:34
@mdimjasevic mdimjasevic temporarily deployed to cachix June 3, 2022 09:34 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix June 7, 2022 09:19 Inactive
@mdimjasevic mdimjasevic force-pushed the polysemy/brig/user-cookie-effects branch from 07f5779 to 4b6c6b7 Compare June 9, 2022 11:30
@mdimjasevic mdimjasevic temporarily deployed to cachix June 9, 2022 11:30 Inactive
Lots of new effects
41835f0 
- It finally compiles!! (though yet to fix the brig-integration package)
@mdimjasevic mdimjasevic force-pushed the polysemy/brig/user-cookie-effects branch from 4b6c6b7 to 41835f0 Compare June 15, 2022 05:24
@mdimjasevic mdimjasevic force-pushed the polysemy/brig/user-cookie-effects branch from 7a25079 to 21b2822 Compare August 9, 2022 09:54
Marko Dimjašević added 2 commits August 12, 2022 14:34
Merge remote-tracking branch 'origin/develop' into polysemy/brig/user…
708fde4 
…-cookie-effects

- It compiles, but there are a lot of undefined's and commented out code
Get rid of one undefined
9b79b8d
@mdimjasevic mdimjasevic force-pushed the polysemy/brig/user-cookie-effects branch from 4f6d22f to 9b79b8d Compare August 12, 2022 12:56
@mdimjasevic mdimjasevic temporarily deployed to cachix September 19, 2022 13:55 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 19, 2022 13:55 Inactive
Marko Dimjašević added 2 commits September 19, 2022 16:17
Resolve a non-TODO
dc55d2e
Remove the Polysemy.Async effect
f105822 
- Most of the time the effect wasn't actually used so I've removed
threading.
@mdimjasevic mdimjasevic temporarily deployed to cachix September 19, 2022 20:47 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 19, 2022 20:48 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 20, 2022 11:34 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 20, 2022 11:34 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 27, 2022 20:19 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix September 27, 2022 20:19 Inactive
Marko Dimjašević added 6 commits September 30, 2022 15:14
Merge remote-tracking branch 'origin/develop' into polysemy/brig/user…
f5e9ed0 
…-cookie-effects
Polysemise Brig.Provider.API.deleteBot
0f69444 
- This commit doesn't compile, but only due to the -Werror flag. Use
sites of deleteBot are commented out as they're wrapped in conduits. The
next step is to handle that.
Merge remote-tracking branch 'origin/develop' into polysemy/brig/user…
b23a3f6 
…-cookie-effects

- This brings in the concurrency effect
Add a TODO to replace the Async effect
a41b0fb
Fix one use site of deleteBot
fd08303
Propagate effect constraints (compiles again)
a3b9a93
@mdimjasevic mdimjasevic temporarily deployed to cachix October 5, 2022 20:52 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix October 5, 2022 20:52 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix October 6, 2022 08:40 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix October 6, 2022 08:40 Inactive
@CLAassistant
Copy link

CLAassistant commented May 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@elland elland added the bit-rot PRs that have bit-rotted label May 11, 2023
@elland elland closed this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stephen-smith stephen-smith stephen-smith left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bit-rot PRs that have bit-rotted ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mdimjasevic @CLAassistant @stephen-smith @elland @zebot