Ensure federator certificate is a valid v1 Certificate resource#2405
Merged
akshaymankar merged 1 commit intodevelopfrom May 18, 2022
Merged
Ensure federator certificate is a valid v1 Certificate resource#2405akshaymankar merged 1 commit intodevelopfrom
akshaymankar merged 1 commit intodevelopfrom
Conversation
This was missed in #2401
jschaul
approved these changes
May 18, 2022
supersven
approved these changes
May 18, 2022
Contributor
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
I've compared this to the current documentation. (https://cert-manager.io/docs/reference/api-docs/#cert-manager.io/v1.CertificatePrivateKey)
Looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed in #2401
Checklist