Skip to content

Ensure federator certificate is a valid v1 Certificate resource #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaymankar merged 1 commit into from
May 18, 2022
+5 −7
Merged

Ensure federator certificate is a valid v1 Certificate resource #2405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions charts/nginx-ingress-services/templates/certificate_federator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,12 @@ spec:
duration: 2160h # 90d, Letsencrypt default; NOTE: changes are ignored by Letsencrypt
renewBefore: 360h # 15d
isCA: false
keyAlgorithm: ecdsa
keySize: 256 # hs-tls only supports p256
keyEncoding: pkcs1
secretName: federator-certificate-secret
# NOTE: disabled due to https://github.com/jetstack/cert-manager/issues/2978
# TODO: enable when fixed (probably when cert-manager:v0.16 released)
#privateKey:
# rotationPolicy: Always
privateKey:
algorithm: ECDSA
size: 256 # hs-tls only supports p256
encoding: PKCS1
rotationPolicy: Always
dnsNames:
- {{ .Values.config.dns.federator }}
{{- end -}}