Skip to content

Comments

chart/nginx-ingress-services: upgrade resources and allow fine-grained configurability#2401

Merged
jschaul merged 8 commits intodevelopfrom
ingress-changes
May 17, 2022
Merged

chart/nginx-ingress-services: upgrade resources and allow fine-grained configurability#2401
jschaul merged 8 commits intodevelopfrom
ingress-changes

Conversation

@jschaul
Copy link
Member

@jschaul jschaul commented May 17, 2022 •
edited
Loading

charts/nginx-ingress-services:

  • Allow more fine-grained control over what services are installed. (e.g. allow webapp/fakeS3 to not be installed, and federator dns name to not be set if not using federator)
  • Upgrade Certificate/Issuer resources: If using cert-manager, you need to have least version 1.0.0 installed (0.15.X will no longer work).

Related to https://github.com/zinfra/cailleach/pull/1079

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):

@jschaul jschaul temporarily deployed to cachix May 17, 2022 10:40 Inactive
@jschaul jschaul requested a review from akshaymankar May 17, 2022 10:40
@jschaul jschaul temporarily deployed to cachix May 17, 2022 11:04 Inactive
@jschaul jschaul temporarily deployed to cachix May 17, 2022 11:11 Inactive
@jschaul jschaul temporarily deployed to cachix May 17, 2022 11:13 Inactive
akshaymankar
akshaymankar reviewed May 17, 2022
View reviewed changes
@akshaymankar akshaymankar temporarily deployed to cachix May 17, 2022 12:52 Inactive
@jschaul @akshaymankar
Apply suggestions from code review
e744e9b 
Co-authored-by: Akshay Mankar <akshay@wire.com>
@jschaul jschaul temporarily deployed to cachix May 17, 2022 13:51 Inactive
@jschaul jschaul changed the title tweak ingress-services chart to allow not installing webapp/s3 chart/nginx-ingress-services: upgrade resources and allow fine-grained configurability May 17, 2022
@jschaul jschaul marked this pull request as ready for review May 17, 2022 14:08
@jschaul jschaul temporarily deployed to cachix May 17, 2022 14:18 Inactive
@jschaul jschaul merged commit 90fc9bf into develop May 17, 2022
@jschaul jschaul deleted the ingress-changes branch May 17, 2022 15:29
akshaymankar added a commit that referenced this pull request May 18, 2022
@akshaymankar
Ensure federator certificate is a valid v1 Certificate resource
03882f1 
This was missed in #2401
@akshaymankar akshaymankar mentioned this pull request May 18, 2022
Merged
3 tasks
akshaymankar added a commit that referenced this pull request May 18, 2022
@akshaymankar
Ensure federator certificate is a valid v1 Certificate resource (#2405)
ea1e40c 
This was missed in #2401
@zebot zebot mentioned this pull request May 18, 2022
Merged
smatting pushed a commit that referenced this pull request Dec 12, 2022
@akshaymankar @smatting
Ensure federator certificate is a valid v1 Certificate resource (#2405)
fa956e3 
This was missed in #2401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jschaul @akshaymankar