-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump winston from 2.2.0-e to 2.2.0 in /electron #1346
build: bump winston from 2.2.0-e to 2.2.0 in /electron #1346
Conversation
Bumps [winston](https://github.com/wireapp/winston) from 2.2.0-e to 2.2.0. - [Release notes](https://github.com/wireapp/winston/releases) - [Changelog](https://github.com/wireapp/winston/blob/master/CHANGELOG.md) - [Commits](https://github.com/wireapp/winston/compare/6526c40fdf9ef4108091aac298ea954bb26493ae...b44062612f63211d047c67050fef5b7624682fb6) Signed-off-by: dependabot[bot] <[email protected]>
@@ -35,7 +35,7 @@ | |||
"request": "2.85.0", | |||
"spellchecker": "3.4.4", | |||
"uuid": "3.2.1", | |||
"winston": "https://github.com/wireapp/winston.git#2.2.0-e" | |||
"winston": "https://github.com/wireapp/winston.git#2.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's interesting: https://github.com/wireapp/winston/releases
Most likely I had to do 2.2.0e
or something.. but I still think that 2.2.0-e
> 2.2.0
/cc @dependabot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's getting picked up as a pre-release version - docs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we want to increase the version but without changing the 2.2.0 (because it comes from upstream and we just have a patch..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS doesn't have a way to do that 😢. In Python you'd use a +
separator to specify a "local version identifier" for exactly that use case, but that's not available here.
I'd recommend just closing this PR and letting Dependabot update you when a new version comes out. I'd also like to add functionality for Dependabot to detect that you're using a fork and create PRs to move you to the main library if/when the commit you're pinned on on that fork is included in a release, but it's one for the future, not now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @greysteil! Sometimes you are faster than bots :)
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps winston from 2.2.0-e to 2.2.0.
Changelog
Sourced from winston's changelog.
Commits
You can also trigger a rebase of this PR by commenting
@dependabot rebase
.If you'd like to skip this version, you can just close this PR. If you have any feedback just mention @dependabot in the comments below.