Update transports.js #731
Closed
Update transports.js #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes winston consumable by browserify - which does a static analysis of dependencies to bundle javascript.
| transports.__defineGetter__('CONSOLE', function () { |
There was a problem hiding this comment.
Casing is wrong on all of these. Would be:
transports.__defineGetter__('Console', function () {Also you should use Object.defineProperty not __defineGetter__
|
+1 once the syntax is updated. |
indexzero
added a commit
that referenced
this pull request
Oct 29, 2015
…e file system in `lib/transports.js`. Fixes #731.
|
Fixed in 07322af |
Merged
indexzero
added a commit
that referenced
this pull request
Oct 29, 2015
…e file system in `lib/transports.js`. Fixes #731.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes winston consumable by browserify - which does a static analysis of dependencies to bundle javascript.
See: serverless/serverless#253