Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colors stopped working in 1.0.0 #669

Closed
pateljatin opened this issue Jul 17, 2015 · 6 comments
Closed

colors stopped working in 1.0.0 #669

pateljatin opened this issue Jul 17, 2015 · 6 comments

Comments

@pateljatin
Copy link

Hi,

Unless, I'm missing something, the default colors as well as the custom colors stopped working in 1.0.0.
When I install 0.9.0, it shows just fine. All I use is colorize:true option (default) and it used to work in 1.0.0.

Any ideas, what's changed?

Thanks!

@pgrodrigues
Copy link

Hi @pateljatin,

I ran across the same problem and even opened an issue here #648. That happens because you are probably using grunt-concurrent 2.0.0 alongside winston 1.0.1 or 1.0.0.

To get colors back you can use grunt-concurrent 2.0.0 and winston 0.9.0 or grunt-concurrent 1.0.1 and winston 1.0.1. They don't seem to like each other in their most recent versions :)

In case you are not using grunt-concurrent then it might be something else.

@stnever
Copy link

stnever commented Aug 26, 2015

I'm having the same problem (color works on 0.9.0 but don't on 1.0.0). I'm not using grunt, nor grunt-concurrent.

I believe the relevant change is with regard to using colors/safe instead of the monkey-patching colors module: https://github.com/winstonjs/winston/blob/master/CHANGELOG.md

Also see #587 . Will attempt to create a minimal reproducible scenario later.

@fiznool
Copy link
Contributor

fiznool commented Nov 9, 2015

Yep, this is a dup of #609. There is a workaround described in that issue.

@pgrodrigues
Copy link

In the case of using grunt-concurrent together with winston, grunt-concurrent was updated as well, and as of version 2.0.4 the issue seemed to disappear.

Maybe this can be closed.

@indexzero
Copy link
Member

Closing as a duplicate of #609.

@indexzero
Copy link
Member

Fixed in #751. Released in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants