-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] #732
Merged
[email protected] #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2015
a57bbb0
to
0d955d3
Compare
… `winstonjs/winston-daily-rotate-file`.
… `.addFilter` since they are just simple Arrays of functions.
[breaking] No longer respect the `handleExceptions` option to `new winston.Logger`. Instead just pass in the `exceptionHandlers` option itself.
…tainable without it).
…all logic previously in the `winston.Logger` constructor function. [api] `winston.Logger` constructor function and `Logger.prototype.configure` set filters in addition to rewriters.
…onsistent with `rewriter` and log functions.
… or "meta" objects based on the occurance of the format expressions in the base message to be logged.
…e file system in `lib/transports.js`. Fixes #731.
…t to be consistent with the `File` transport.
indexzero
added a commit
that referenced
this pull request
Oct 30, 2015
cjbarth
pushed a commit
to cjbarth/winston
that referenced
this pull request
Feb 29, 2016
…`addFilter` functions from `winston` winstonjs#732
cjbarth
pushed a commit
to cjbarth/winston
that referenced
this pull request
Feb 29, 2016
…`addFilter` functions from `winston` winstonjs#732
cjbarth
pushed a commit
to cjbarth/winston
that referenced
this pull request
Feb 29, 2016
…`addFilter` functions from `winston` winstonjs#732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected]
release. Do not merge.Breaking changes
Most important
winston.transports.DailyRotateFile
into a separate module:require('winston-daily-rotate-file');
npm
andcli
configs to conform to RFC524. Fixes Fix the ordering of the colors in the npm config #424 Syslog Levels #406 Reverse log level order for all levels so that syslog can be used again #290filter
function to be consistent withrewriter
and log functions:Other breaking changes
winston.transports.Webhook
. Usewinston.transports.Http
instead.Logger.prototype.addRewriter
andLogger.prototype.addFilter
since they just push to an Array of functions. Uselogger.filters.push
orlogger.rewriters.push
explicitly instead.handleExceptions
option tonew winston.Logger
. Instead just pass in theexceptionHandlers
option itself.Logger.prototype.extend
functionalityNew features
Logger.prototype.configure
which now contains all logic previously in thewinston.Logger
constructor function. (indexzero
)coreybutler
)eol
option to theConsole
transport. (aquavitae
)lib/transports.js
for better static analysis. (indexzero
)Fixes, refactoring, and optimizations. OH MY!
File
transport to be anobjectMode
writable stream. (stambata
)indexzero
)indexzero
)