Detached ArrayBuffer objects should not throw#605
Merged
Conversation
Instead treat them the same as the empty byte sequence as implementations have been doing since forever. This also performs the IsDetachedBuffer abstract operation on the correct object. Fixes #151.
domenic
reviewed
Jan 9, 2019
littledan
approved these changes
Jan 9, 2019
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 9, 2019
While IDL said this should throw, that was in error: whatwg/webidl#605.
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 10, 2019
While IDL said this should throw, that was in error: whatwg/webidl#605.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 10, 2019
Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 11, 2019
Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#621897}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 11, 2019
Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#621897}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 11, 2019
Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#621897}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 5, 2019
…rs, a=testonly Automatic update from web-platform-tests TextDecoderStream: Permit detached buffers Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#621897} -- wpt-commits: 35d1ca9cb52f755566ba6681fe555626379b9e2c wpt-pr: 14794
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Feb 6, 2019
…rs, a=testonly Automatic update from web-platform-tests TextDecoderStream: Permit detached buffers Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#621897} -- wpt-commits: 35d1ca9cb52f755566ba6681fe555626379b9e2c wpt-pr: 14794
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 7, 2019
…rs, a=testonly Automatic update from web-platform-tests TextDecoderStream: Permit detached buffers Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#621897} -- wpt-commits: 35d1ca9cb52f755566ba6681fe555626379b9e2c wpt-pr: 14794
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Feb 8, 2019
…rs, a=testonly Automatic update from web-platform-tests TextDecoderStream: Permit detached buffers Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#621897} -- wpt-commits: 35d1ca9cb52f755566ba6681fe555626379b9e2c wpt-pr: 14794
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…rs, a=testonly Automatic update from web-platform-tests TextDecoderStream: Permit detached buffers Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbellchromium.org> Commit-Queue: Adam Rice <riceachromium.org> Cr-Commit-Position: refs/heads/master{#621897} -- wpt-commits: 35d1ca9cb52f755566ba6681fe555626379b9e2c wpt-pr: 14794 UltraBlame original commit: 5ddb0794d6abeb42541ab50cc3519b05e43cab87
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…rs, a=testonly Automatic update from web-platform-tests TextDecoderStream: Permit detached buffers Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbellchromium.org> Commit-Queue: Adam Rice <riceachromium.org> Cr-Commit-Position: refs/heads/master{#621897} -- wpt-commits: 35d1ca9cb52f755566ba6681fe555626379b9e2c wpt-pr: 14794 UltraBlame original commit: 41aee3a78bbe1bddf630d2503069cb793ecea72c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…rs, a=testonly Automatic update from web-platform-tests TextDecoderStream: Permit detached buffers Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbellchromium.org> Commit-Queue: Adam Rice <riceachromium.org> Cr-Commit-Position: refs/heads/master{#621897} -- wpt-commits: 35d1ca9cb52f755566ba6681fe555626379b9e2c wpt-pr: 14794 UltraBlame original commit: 5ddb0794d6abeb42541ab50cc3519b05e43cab87
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…rs, a=testonly Automatic update from web-platform-tests TextDecoderStream: Permit detached buffers Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbellchromium.org> Commit-Queue: Adam Rice <riceachromium.org> Cr-Commit-Position: refs/heads/master{#621897} -- wpt-commits: 35d1ca9cb52f755566ba6681fe555626379b9e2c wpt-pr: 14794 UltraBlame original commit: 41aee3a78bbe1bddf630d2503069cb793ecea72c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…rs, a=testonly Automatic update from web-platform-tests TextDecoderStream: Permit detached buffers Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbellchromium.org> Commit-Queue: Adam Rice <riceachromium.org> Cr-Commit-Position: refs/heads/master{#621897} -- wpt-commits: 35d1ca9cb52f755566ba6681fe555626379b9e2c wpt-pr: 14794 UltraBlame original commit: 5ddb0794d6abeb42541ab50cc3519b05e43cab87
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…rs, a=testonly Automatic update from web-platform-tests TextDecoderStream: Permit detached buffers Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbellchromium.org> Commit-Queue: Adam Rice <riceachromium.org> Cr-Commit-Position: refs/heads/master{#621897} -- wpt-commits: 35d1ca9cb52f755566ba6681fe555626379b9e2c wpt-pr: 14794 UltraBlame original commit: 41aee3a78bbe1bddf630d2503069cb793ecea72c
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…rs, a=testonly Automatic update from web-platform-tests TextDecoderStream: Permit detached buffers Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#621897} -- wpt-commits: 35d1ca9cb52f755566ba6681fe555626379b9e2c wpt-pr: 14794
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead treat them the same as the empty byte sequence as implementations have been doing since forever.
This also performs the IsDetachedBuffer abstract operation on the correct object.
Fixes #151.
Preview | Diff