Encoding: align encodeInto() test with reality#14775
Conversation
While IDL said this should throw, that was in error: whatwg/webidl#605.
|
There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
|
Interesting. My slow and dumb polyfill didn't pass this test, but I assumed it was just because I wasn't trying hard enough. I will retest once you've fixed @Honry's comments. |
|
Thanks @Honry! Out-of-band Henri told me that it didn't work in workers, so I've fixed that too. And Domenic helped me figure out a way to make object destructuring work without a leading let/const. 😊 |
|
With the latest changes changes to the test, my implementation of the feature passes the test, so the detachment part is now reality-aligned at least for Gecko purposes. |
|
Retested. All tests pass now, including in a worker. |
… r=hsivonen. web-platform-tests/wpt#14505 web-platform-tests/wpt#14775 UltraBlame original commit: 3c73631c8237077acb3795e51a2a2ea6016247df
… r=hsivonen. web-platform-tests/wpt#14505 web-platform-tests/wpt#14775 UltraBlame original commit: 3c73631c8237077acb3795e51a2a2ea6016247df
… r=hsivonen. web-platform-tests/wpt#14505 web-platform-tests/wpt#14775 UltraBlame original commit: 3c73631c8237077acb3795e51a2a2ea6016247df
7 participants
While IDL said this should throw, that was in error: whatwg/webidl#605.