TextDecoderStream: Permit detached buffers#14794
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Jan 11, 2019
Merged
TextDecoderStream: Permit detached buffers#14794chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Jan 10, 2019
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
Since whatwg/webidl#605 converting a chunk to a BufferSource no longer throws if the chunk is detached. Update the TextDecoderStream implementation and tests to match the new behaviour. Change-Id: I26230d9cbfce871b3dae75e612539564d4578977 Reviewed-on: https://chromium-review.googlesource.com/c/1404906 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#621897}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1404906
branch
from
b1eab3b to
ededc2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since whatwg/webidl#605 converting a chunk to a
BufferSource no longer throws if the chunk is detached. Update the
TextDecoderStream implementation and tests to match the new behaviour.
Change-Id: I26230d9cbfce871b3dae75e612539564d4578977
Reviewed-on: https://chromium-review.googlesource.com/c/1404906
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621897}