-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing description for allow-downloads keyword #6418
Conversation
Closes #6411 It has just borrowed from the text of sandboxed-downloads-browsing-context-flag. So, it may be too descriptive.
context">auxiliary browsing contexts</span> respectively. <ref spec=POINTERLOCK> | ||
<ref spec=SCREENORIENTATION> <ref spec=PRESENTATION></p> | ||
context">auxiliary browsing contexts</span> respectively. The <code | ||
data-x="attr-iframe-sandbox-allow-downloads">allow-downloads</code> keyword re-enables content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! What do you think of something shorter like "allows content to perform downloads"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed as you suggested, so that to be as brief as other descriptions.
(I thought it might be better to give a more detailed description, but readers can follow the referenced links from the keyword definition for details.)
Perfect, thank you! The last step is to have you or your employer sign the Participant Agreement. |
Ok, I just have signed the Participant Agreement. |
I'm sorry to say we can't accept legal agreements signed using pseudonyms, per whatwg/sg#93 :(. I should have realized this might have been an issue before asking you to do this work. If you're willing to sign using your legal name, you can send a pull request editing https://github.com/whatwg/participant-data/blob/main/individuals.json . Otherwise, let me know, and I can take over trying to fix this issue. |
Sorry for taking your time; I should have asked before proceeding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Closes #6411
It has just borrowed from the text of sandboxed-downloads-browsing-context-flag.
So, it may be too descriptive.
/iframe-embed-object.html ( diff )