Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing description for allow-downloads keyword #6418

Merged
merged 4 commits into from
Mar 17, 2021
Merged

Add missing description for allow-downloads keyword #6418

merged 4 commits into from
Mar 17, 2021

Conversation

triple-underscore
Copy link
Contributor

@triple-underscore triple-underscore commented Feb 26, 2021

Closes #6411

It has just borrowed from the text of sandboxed-downloads-browsing-context-flag.
So, it may be too descriptive.


/iframe-embed-object.html ( diff )

context">auxiliary browsing contexts</span> respectively. <ref spec=POINTERLOCK>
<ref spec=SCREENORIENTATION> <ref spec=PRESENTATION></p>
context">auxiliary browsing contexts</span> respectively. The <code
data-x="attr-iframe-sandbox-allow-downloads">allow-downloads</code> keyword re-enables content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! What do you think of something shorter like "allows content to perform downloads"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed as you suggested, so that to be as brief as other descriptions.
(I thought it might be better to give a more detailed description, but readers can follow the referenced links from the keyword definition for details.)

@domenic
Copy link
Member

domenic commented Mar 15, 2021

Perfect, thank you! The last step is to have you or your employer sign the Participant Agreement.

@triple-underscore
Copy link
Contributor Author

Ok, I just have signed the Participant Agreement.

@domenic
Copy link
Member

domenic commented Mar 16, 2021

I'm sorry to say we can't accept legal agreements signed using pseudonyms, per whatwg/sg#93 :(. I should have realized this might have been an issue before asking you to do this work. If you're willing to sign using your legal name, you can send a pull request editing https://github.com/whatwg/participant-data/blob/main/individuals.json . Otherwise, let me know, and I can take over trying to fix this issue.

@triple-underscore
Copy link
Contributor Author

Sorry for taking your time; I should have asked before proceeding.
(I sent a pull request for individuals.json.)

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@domenic domenic merged commit 3dd9861 into whatwg:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Missing description for allow-downloads
2 participants