Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing description for allow-downloads #6411

Closed
triple-underscore opened this issue Feb 24, 2021 · 6 comments · Fixed by #6418
Closed

Missing description for allow-downloads #6411

triple-underscore opened this issue Feb 24, 2021 · 6 comments · Fixed by #6418
Labels
clarification Standard could be clearer topic: sandbox

Comments

@triple-underscore
Copy link
Contributor

In section 4.8.5 The iframe element:

When the attribute is set, the content is treated as being from a unique origin, forms, scripts, and various potentially annoying APIs are disabled, links are prevented from targeting other browsing contexts, and plugins are secured. The allow-same-origin keyword causes the content to be treated as being from its real origin instead of forcing it into a unique origin; the allow-top-navigation keyword allows the content to navigate its top-level browsing context; the allow-top-navigation-by-user-activation keyword behaves similarly but allows such navigation only when the browsing context's active window has transient activation; and the allow-forms, allow-modals, allow-orientation-lock, allow-pointer-lock, allow-popups, allow-presentation, allow-scripts, and allow-popups-to-escape-sandbox keywords re-enable forms, modal dialogs, screen orientation lock, the pointer lock API, popups, the presentation API, scripts, and the creation of unsandboxed auxiliary browsing contexts respectively. [POINTERLOCK] [SCREENORIENTATION] [PRESENTATION]

For completeness, this paragraph should include a description for allow-downloads keyword, something similar to the description of sandboxed-downloads-browsing-context-flag.

@annevk annevk added clarification Standard could be clearer topic: sandbox labels Feb 24, 2021
@annevk
Copy link
Member

annevk commented Feb 24, 2021

cc @xyaoinum

@domenic
Copy link
Member

domenic commented Feb 24, 2021

Would you like to submit a pull request with such a description, @triple-underscore?

@triple-underscore
Copy link
Contributor Author

I created a pull request as above, though I'm not sure whether this is a right way.
By the way, how do I edit the comment in the commit (“It has just borrowed from ...”)?

@sideshowbarker
Copy link
Contributor

By the way, how do I edit the comment in the commit (“It has just borrowed from ...”)?

From the command line:

git commit --amend

That should launch your text editor and allow you to change the commit message and save it.

After that:

git push -f

You need the -f to force git to overwrite the previous commit you pushed.

@triple-underscore
Copy link
Contributor Author

Thank you @sideshowbarker, It seems that it has been done. (but, since I (mistakenly?) inserted a some extra operation ("Fetch Origin" in the Github desktop), an extra commit added in the pull request.)

@sideshowbarker
Copy link
Contributor

Thank you @sideshowbarker, It seems that it has been done. (but, since I (mistakenly?) inserted a some extra operation ("Fetch Origin" in the Github desktop), an extra commit added in the pull request.)

That’s fine — later, that extra commit will just be squashed into the first one on the branch (prior to merging)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer topic: sandbox
Development

Successfully merging a pull request may close this issue.

4 participants