Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing description for allow-downloads keyword #6418

Merged
merged 4 commits into from
Mar 17, 2021
Merged

Add missing description for allow-downloads keyword #6418

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb436dd
Add missing description for allow-downloads keyword
triple-underscore Feb 26, 2021
716e991
Add missing description for allow-downloads keyword
triple-underscore Feb 26, 2021
8f6d68a
Merge branch 'main' of https://github.com/triple-underscore/html into…
triple-underscore Feb 27, 2021
0b50826
Update source
triple-underscore Mar 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30452,8 +30452,12 @@ interface <dfn>HTMLIFrameElement</dfn> : <span>HTMLElement</span> {
data-x="attr-iframe-sandbox-allow-popups-to-escape-sandbox">allow-popups-to-escape-sandbox</code>
keywords re-enable forms, modal dialogs, screen orientation lock, the pointer lock API, popups,
the presentation API, scripts, and the creation of unsandboxed <span data-x="auxiliary browsing
context">auxiliary browsing contexts</span> respectively. <ref spec=POINTERLOCK>
<ref spec=SCREENORIENTATION> <ref spec=PRESENTATION></p>
context">auxiliary browsing contexts</span> respectively. The <code
data-x="attr-iframe-sandbox-allow-downloads">allow-downloads</code> keyword re-enables content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! What do you think of something shorter like "allows content to perform downloads"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed as you suggested, so that to be as brief as other descriptions.
(I thought it might be better to give a more detailed description, but readers can follow the referenced links from the keyword definition for details.)

from initiating or instantiating downloads, whether <span data-x="downloading hyperlinks">download
hyperlinks</span> or through <span data-x="process a navigate response">navigation</span> that
gets handled <span>as a download</span>. <ref spec=POINTERLOCK> <ref spec=SCREENORIENTATION> <ref
spec=PRESENTATION></p>

<p>The <code
data-x="attr-iframe-sandbox-allow-top-navigation">allow-top-navigation</code> and <code
Expand Down