-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CSI-344): delete filesystems out-of-band if not waiting for object deletion #477
Open
sergeyberezansky
wants to merge
2
commits into
dev
Choose a base branch
from
sergey/remove-filesystem-nfs-permissions-out-of-band
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(CSI-344): delete filesystems out-of-band if not waiting for object deletion #477
sergeyberezansky
wants to merge
2
commits into
dev
from
sergey/remove-filesystem-nfs-permissions-out-of-band
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2025
Merged
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (03/11/25)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
dc109c0
to
7c18afd
Compare
7c993f4
to
e8f8ebc
Compare
c53f25d
to
350def4
Compare
8da3304
to
31f7341
Compare
350def4
to
ff24efe
Compare
31f7341
to
2d1fe67
Compare
ff24efe
to
e551e20
Compare
2d1fe67
to
9695a20
Compare
This was referenced Mar 12, 2025
9695a20
to
809a6e3
Compare
1a1c89e
to
5a3a384
Compare
809a6e3
to
7b1bf2b
Compare
7b1bf2b
to
2f33823
Compare
5a3a384
to
3e3c98f
Compare
2f33823
to
418375b
Compare
418375b
to
4c85fb2
Compare
3e3c98f
to
3e377ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved CSI plugin latency on DeleteVolume by moving the deletion of actual filesystem and NFS permissions to asynchronous flow. This behavior is configurable via
pluginConfig.waitForObjectDeletion
flagWhat changed?
getUnderlyingSnapshots
How to test?
Why make this change?
These changes address latency of DeleteVolume request by moving the deletion into out-of-band thread. The retry logic for NFS permission deletion helps overcome transient API failures that could possibly block filesystem deletion, for example in case of multiple deletions at once that require massive changes to NFS server reconfiguration.