breaking(CSI-314): remove legacy volume support #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (01/28/25)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
sergeyberezansky
force-pushed
the
sergey/remove-legacy-volumes
branch
from
35309fd to
73c0365
Compare
sergeyberezansky
force-pushed
the
sergey/remove-legacy-volumes
branch
from
c3ae164 to
0afffa4
Compare
This was referenced Feb 9, 2025
sergeyberezansky
force-pushed
the
sergey/remove-legacy-volumes
branch
from
0afffa4 to
2921bc4
Compare
sergeyberezansky
changed the base branch from
graphite-base/435
to
sergey/unify-mounters
This was referenced Mar 12, 2025
Merged
sergeyberezansky
force-pushed
the
sergey/remove-legacy-volumes
branch
from
2921bc4 to
dc90016
Compare
sergeyberezansky
force-pushed
the
sergey/unify-mounters
branch
from
93d69de to
a9978d0
Compare
sergeyberezansky
force-pushed
the
sergey/unify-mounters
branch
from
a9978d0 to
1023d79
Compare
sergeyberezansky
force-pushed
the
sergey/remove-legacy-volumes
branch
from
dc90016 to
37eff82
Compare
sergeyberezansky
force-pushed
the
sergey/unify-mounters
branch
from
1023d79 to
1453801
Compare
sergeyberezansky
force-pushed
the
sergey/remove-legacy-volumes
branch
from
37eff82 to
d0d9685
Compare
sergeyberezansky
force-pushed
the
sergey/remove-legacy-volumes
branch
from
d0d9685 to
dd9168f
Compare
sergeyberezansky
force-pushed
the
sergey/unify-mounters
branch
from
1453801 to
ff1772e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Removed support for legacy volumes (without binding to REST API client). This change is breaking.
What changed?
How to test?
Why make this change?
The previous implementation had performed NFS client group registration attempt on each mount, causing lots of additional API calls and reducing overall performance of volume provisioning and publishing. This change breaks the process into 2 parts, while client registration is performed during API client initialization, while only the NFS permission is ensured during mount.