-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CSI-316): support encryption with custom settings per filesystem #444
Draft
sergeyberezansky
wants to merge
11
commits into
sergey/remove-legacy-volumes
Choose a base branch
from
sergey/per-filesystem-encryption
base: sergey/remove-legacy-volumes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(CSI-316): support encryption with custom settings per filesystem #444
sergeyberezansky
wants to merge
11
commits into
sergey/remove-legacy-volumes
from
sergey/per-filesystem-encryption
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
Merged
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fbf1b36
to
2134746
Compare
b5c9448
to
5d29834
Compare
2134746
to
0f361eb
Compare
0f361eb
to
4dbe7d8
Compare
5d29834
to
637598a
Compare
dac3d09
to
d833576
Compare
637598a
to
da199a3
Compare
d833576
to
9b2a66e
Compare
da199a3
to
837a80a
Compare
9b2a66e
to
4836fbb
Compare
837a80a
to
194d682
Compare
9dc3dee
to
abbd5b9
Compare
194d682
to
8f31fce
Compare
8f31fce
to
e07aba9
Compare
abbd5b9
to
706ce3c
Compare
cea4942
to
263dac6
Compare
263dac6
to
124da4d
Compare
d0abd34
to
f11ba49
Compare
124da4d
to
5203425
Compare
This was referenced Mar 12, 2025
dc90016
to
37eff82
Compare
5203425
to
01519d8
Compare
37eff82
to
d0d9685
Compare
01519d8
to
ac8d264
Compare
…isting filesystem
d0d9685
to
dd9168f
Compare
ac8d264
to
25e5865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for encrypted filesystem-backed volumes in WEKA CSI using pre-existing KMS keys. This is an interim step between encryption using only a single cluster-wide key and a full-fledged automated key management per filesystem.
What changed?
How to test?
storageclass-wekafs-fs-encryption-key-in-secret.yaml
csi-wekafs-api-secret-kms-encryption-key-in-secret.yaml
pvc-wekafs-fs-encryption-key-in-secret.yaml
csi-app-on-fs-encryption-key-in-secret.yaml
Why make this change?
To enable secure data storage by supporting filesystem-level encryption in WEKA CSI, allowing users to protect their data using pre-existing KMS keys. This feature allows tenant separation by having different encryption keys and not only a cluster-wide key.