Skip to content

docs(wework): clarify desktop e2e coverage - #2171

Merged
qdaxb merged 1 commit into
mainfrom
docs/wework-desktop-e2e-guidance
Jul 24, 2026
Merged

qdaxb merged 1 commit into
mainfrom
docs/wework-desktop-e2e-guidance

Conversation

@qdaxb

@qdaxb qdaxb commented Jul 24, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • Require Wework E2E regression cases to live under e2e/desktop/ and use the existing desktop runner.
  • Prevent per-scenario package scripts and GitHub Actions commands unless a genuinely different CI environment or job boundary is required.

Why

Desktop regressions must run through the entry points covered by GitHub CI. Reusing the runner and scenario discovery also keeps the test interface maintainable instead of growing one command per case.

Impact

Contributors now have explicit guidance for adding Wework desktop E2E coverage that CI will execute.

Validation

  • git diff --check
  • Documentation-only change; no runtime tests required.

Summary by CodeRabbit

  • Documentation
    • Clarified testing guidance for desktop end-to-end regression cases.
    • Documented how to run new scenarios through the existing desktop test commands and CI jobs.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: aad4cc90-0dc3-4a26-b579-179d2c34ba0d

📥 Commits

Reviewing files that changed from the base of the PR and between 33b820a and 3a55101.

📒 Files selected for processing (1)
  • wework/AGENTS.md

📝 Walkthrough

Walkthrough

Updated wework/AGENTS.md testing guidance to require desktop E2E regressions under e2e/desktop/ and execution through the existing desktop runner and GitHub CI jobs.

Changes

Desktop E2E Guidance

Layer / File(s) Summary
Desktop E2E runner guidance
wework/AGENTS.md
Testing instructions require desktop E2E cases to use the existing e2e:desktop runner and CI variants instead of adding per-scenario commands, unless a separate environment or job boundary is needed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: micro66

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/wework-desktop-e2e-guidance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb marked this pull request as ready for review July 24, 2026 05:59
@qdaxb
qdaxb merged commit e86e2a7 into main Jul 24, 2026
21 of 23 checks passed
@qdaxb
qdaxb deleted the docs/wework-desktop-e2e-guidance branch July 24, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant