Repository navigation
fix(wework): restore historical message images - #2147
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAttachment persistence now retains local filesystem paths for image previews. Preview rendering falls back to those paths, historical message restoration is tested, task lifecycle E2E coverage verifies reopened previews, and English and Chinese documentation describe the behavior. ChangesLocal image preview persistence
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
local_pathfor existing historical messagesRoot cause
Local images used a transient
blob:URL while composing. Session persistence removed that URL but did not replace it with the attachment's durablelocal_path. After reopening a conversation, the preview attempted the remote attachment download path with a local negative attachment ID and rendered only a file placeholder.User impact
Images sent from the local Wework runtime remain visible after switching conversations or reopening Wework, provided the original local attachment file still exists.
Validation
pnpm --filter wework test --run src/lib/attachments.test.ts src/components/chat/MessageList.test.tsx(123 tests passed)pnpm --filter wework e2e:desktop:attachment-only-sidebarFinal desktop E2E evidence was generated under:
wework/test-results/desktop-e2e/2026-07-23T05-34-22-644Z-31538/The screenshot chain covers the first image submission and completion, second image submission and completion, reopening Wework and restoring the second conversation image, then switching to and restoring the first conversation image.
Summary by CodeRabbit
Bug Fixes
Tests