Repository navigation
fix(wework): show reconnecting stream status - #2061
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughAdds end-to-end reconnect handling: retryable runtime errors create one transient reconnecting block, the UI displays and clears it, repeated user messages reconcile idempotently, and desktop E2E tests simulate interrupted and resumed responses. ChangesReconnect recovery
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant DesktopE2E
participant DesktopE2EServer
participant CodexNotificationEventMapper
participant ToolBlocksDisplay
DesktopE2E->>DesktopE2EServer: start reconnect scenario
DesktopE2EServer-->>DesktopE2E: interrupt first SSE response
DesktopE2EServer->>CodexNotificationEventMapper: retryable error notification
CodexNotificationEventMapper->>ToolBlocksDisplay: create runtime_reconnecting block
DesktopE2E->>DesktopE2EServer: release reconnect completion
DesktopE2EServer-->>CodexNotificationEventMapper: resumed completion response
CodexNotificationEventMapper->>ToolBlocksDisplay: mark reconnecting block done
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
marked this pull request as ready for review
July 20, 2026 03:09
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What\n\n- surface Codex retryable stream errors as a transient Wework processing block\n- render a subtle one-line localized reconnecting status with the existing shimmer treatment\n- clear the status as soon as model events resume\n- add unit coverage and a real Tauri disconnect/reconnect recovery flow with screenshot evidence\n\n## Why\n\nRelease logs around 06:54 showed repeated upstream SSE timeout/reconnect attempts while local IPC and transcript polling remained responsive. The desktop UI had no feedback during that gap, so output appeared frozen even though Codex was retrying.\n\n## Impact\n\nUsers now see a lightweight “连接中断,正在重连…” status only while automatic reconnection is active. Normal output resumes without leaving a stale status.\n\n## Checks\n\n- real Tauri reconnect E2E: streaming → reconnecting → recovered\n- Wework ESLint\n- Wework TypeScript\n- Wework unit tests (1821 passed)\n- Executor cargo fmt\n- Executor cargo test --all-features --lib\n- Executor cargo clippy\n
Summary by CodeRabbit
New Features
Bug Fixes
Tests