-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack 4 - optimization section under configuration #1968
Comments
Is the intention to tackle some examples on best solutions? Or simply explain configurations of each option? I'm getting the feeling that this could generate duplicated content easily if we are not careful. |
The plan was to mention these things and what they are doing, what options are available and what the defaults are. Do you think the list should be extended or shortened @jeremenichelli ? |
My fear is to have duplicated references for the same content, but we can always give it a try and see if it does work. There are config that naturally are already present like the plugins for example, so it owuld be good to breifly describe them and link to their proper page, but extend the content on the ones that actually have no other explanation on the site. |
I got your point, yes everything that has its core page from the list above will be only briefly mentioned and linked to 👍 i did not understand your concern from the first time 😓 😆 @jeremenichelli |
@EugeneHlushko don't worry man, all good. Let me know when you have something, I'll checkout the PR and give it a look locally to see how the final content looks. |
// src/index.ts
import './polyfills';
export function f() {}
// src/polyfills.ts
import 'promise-polyfill/src/polyfill';
import 'reflect-metadata'; // npm package The above content is my TypeScript code. // config1
// package.json
{
"sideEffects": [
"src/polyfills.ts"
],
} // config2
// package.json
{
"sideEffects": [
"src/index.ts"
],
} The bundle file include I think |
@Aqours can you put this in a separate issue, I don't it belongs to this discussion and tell us what would work for you better as content in that section. Thanks in advance! |
* document `optimization.portableRecords` * Fixes #1968 🎉 🎉 🎉
All done! |
The text was updated successfully, but these errors were encountered: